New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601726 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

LayoutTest frame-focus-before-load.html times out on WebKit Win7 (dbg)

Project Member Reported by magjed@chromium.org, Apr 8 2016

Issue description

The test http/tests/incremental/frame-focus-before-load.html has started to time out on WebKit Win7 (dbg):  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)

Blame range: http://test-results.appspot.com/revision_range?start=385693&end=385701

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22cc18aa4367c15ee90942057143ef78e0a9135

commit c22cc18aa4367c15ee90942057143ef78e0a9135
Author: magjed <magjed@chromium.org>
Date: Fri Apr 08 08:23:34 2016

Disable LayoutTest frame-focus-before-load.html on Win7

BUG= 601726 
TBR=beaudoin
NOTRY=true

Review URL: https://codereview.chromium.org/1870053002

Cr-Commit-Position: refs/heads/master@{#386017}

[modify] https://crrev.com/c22cc18aa4367c15ee90942057143ef78e0a9135/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9949a926f205a4c646bb187811b0ceff2b11af4

commit b9949a926f205a4c646bb187811b0ceff2b11af4
Author: lukasza <lukasza@chromium.org>
Date: Tue Apr 12 21:53:12 2016

Mark h/t/incremental/frame-focus-before-load.html as slow on all platforms.

This test has timed out recently on Site Isolation FYI bot [1]
and takes around 2 seconds to run locally, so it seems we should
1. mark it as [ Slow ], not as [ Timeout ]
2. have the test expectation apply to all platforms
   (the FYI bot is Linux)

[1] https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/8762

BUG= 601726 
TBR=beaudoin

Review URL: https://codereview.chromium.org/1875363003

Cr-Commit-Position: refs/heads/master@{#386815}

[modify] https://crrev.com/b9949a926f205a4c646bb187811b0ceff2b11af4/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/b9949a926f205a4c646bb187811b0ceff2b11af4/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 4 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests Blink
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead. Merging these to component:Blink for the Blink rotation to pick up and re-triage as appropriate. 
Components: -Blink Blink>Focus

Comment 6 by tkent@chromium.org, Jun 24 2016

Status: Available (was: Untriaged)
The test looks not slow now.  All bots finish it in 1-2 seconds.
We should remove a TestExpectation entry.

Comment 7 by kochi@chromium.org, Jul 21 2016

Owner: kochi@chromium.org
Remove entry CL:
https://codereview.chromium.org/2172543002/

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57954f33c1620558ce3403ffdb49ba10b4a8d35d

commit 57954f33c1620558ce3403ffdb49ba10b4a8d35d
Author: kochi <kochi@chromium.org>
Date: Fri Jul 22 03:56:41 2016

Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG= 601726 
NOTRY=true

Review-Url: https://codereview.chromium.org/2172543002
Cr-Commit-Position: refs/heads/master@{#407053}

[modify] https://crrev.com/57954f33c1620558ce3403ffdb49ba10b4a8d35d/third_party/WebKit/LayoutTests/SlowTests

Comment 9 by kochi@chromium.org, Jul 22 2016

Status: Fixed (was: Available)
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment