New issue
Advanced search Search tips

Issue 601717 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Keyboard shortcut overlay still shows "Search" when search key is mapped to "Backspace"

Project Member Reported by michae...@chromium.org, Apr 8 2016

Issue description

Version: 50.0.2661.57
OS: Chrome

What steps will reproduce the problem?
(1) In chrome://settings/keyboard-overlay, map Search to Backspace and hit OK.
(2) Press Ctrl + Alt + ? to open the shortcut overlay.

Expected: the physical search key is shown as Backspace.
Actual: the physical search key is shown as Search.

If the Search key is remapped to other options (e.g., alt, esc), the keyboard shortcut overlay shows the mapped value as expected.
 
Labels: -Type-Bug Type-Feature
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
Cc: tbuck...@chromium.org
Owner: afakhry@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/727eec5e5bbad2c09f9b9d92576dfad4f86af6be

commit 727eec5e5bbad2c09f9b9d92576dfad4f86af6be
Author: afakhry <afakhry@chromium.org>
Date: Mon Jun 20 21:27:49 2016

Fix keyboard overlay when the Search key is mapped to Backspace

Screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LNEVhSmEtUEI0cXc/view?usp=sharing

BUG= 601717 
TEST=manually
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2082713002
Cr-Commit-Position: refs/heads/master@{#400786}

[modify] https://crrev.com/727eec5e5bbad2c09f9b9d92576dfad4f86af6be/chrome/browser/resources/chromeos/keyboard_overlay.js
[modify] https://crrev.com/727eec5e5bbad2c09f9b9d92576dfad4f86af6be/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Status: Fixed (was: Started)
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment