New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601713 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Bandwidth estimation broken on chromoting webrtc implementation

Project Member Reported by isheriff@chromium.org, Apr 8 2016

Issue description

WebRTC bandwidth estimation is completely broken on both the test and actual socket factory implementation.

After a lot of low-level packet debug, I have identified the issue being the absolute time timestamps that get filled in the RTP extension header. The receiver is unable to estimate time delta on packets due to this and hence the broken behavior
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3943d65cbc744467a489b7013cd736025851ef24

commit 3943d65cbc744467a489b7013cd736025851ef24
Author: isheriff <isheriff@chromium.org>
Date: Fri Apr 08 17:19:54 2016

Fix bandwidth estimation on remoting webrtc

The socket factory implementation on remoting was incorrectly
providing millisecond timestamps for updating the absolute time
RTP extension and this was the cause of the broken bandwidth
estimation on both the tests and the implementation.

On the test, I see significant improvements in the overall latency
numbers. The test itself is still not entirely correct due to
the way the frame ids are handled.

BUG= 601713 

TEST results:

Previously:

Average latency for big frames: 1562.03
Average latency for small frames: 1245.65

Bandwidth fix (with local test fix for unique frame id):

Average latency (ms): 73.851 average loss (%): 0
Average latency for big frames: 277.975
Average latency for small frames: 76.221

Review URL: https://codereview.chromium.org/1866283004

Cr-Commit-Position: refs/heads/master@{#386108}

[modify] https://crrev.com/3943d65cbc744467a489b7013cd736025851ef24/remoting/protocol/chromium_socket_factory.cc
[modify] https://crrev.com/3943d65cbc744467a489b7013cd736025851ef24/remoting/test/fake_socket_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment