Please provide more detailed OS information

Additional Info:

Affected OS: Windows Server 2008R2, Windows 10 Professional (as a local policy settings)

I can confirm this is not working as excepted. Managed to repro the issue.

Any updates on this issue?
I know that the status has not been changed for a few days.

Greg, any ideas?

Gab: It looks like SetupMasterPrefsFromInstallPrefs doesn't handle kImportSavedPasswords / importer::PASSWORDS. DO you recall why?

I may be reading it wrong, but it looks like passwords were automatically imported unless explicitly disabled via policy prior to r210004. From what I can tell, this was changed in the import rewrite, and the ImportSavedPasswords pref (in contrast with the other prefs) is not being used. What do you think?

Hmmm, where in r210004 do you see a change in policy?

This bug doesn't mention it, but I'm assuming we're talking about first run auto-import? (as on manual import, the user decides what to import, not policy/masterprefs)

Regarding SetupMasterPrefsFromInstallPrefs, that method is dealing with installer::master_preferences::kDistroImport*Pref constants (for which there doesn't appear to be a password one..?).
But we also have prefs in chrome/common/pref_names.cc that are redundant for all of these? I'd never realized this and it doesn't make sense as master_prefs/prefs are one and the same and duplicating this doesn't make sense.
FWIW, I like having all the first run only prefs in the former and think we should delete the latter.

I'm happy to help here but I don't have cycles to attend this right now.

Group Policy generally influences Chrome by way of automatic policy->pref mappings. This is the reason for the pref_names values (introduced as per  issue 71080 ).

After digging deeper, it looks like the initial commit for policy-driven import didn't include passwords (r96921), so you're off the hook, Gab. :-)

The question is "why has first-run auto import never imported passwords?" I have no idea. It looks like the various import_foo master prefs were added on an as-needed basis. Since first-run has never supported importing passwords, the ImportSavedPasswords policy setting has never had any influence on first-run auto import. This looks like a simple oversight on the initial policy commit.

In summary, this is a legitimate bug that has existed since the ImportFoo policy settings were introduced in Chrome 15.

Is this a critical feature?

Definitely don't think this is critical given First Run Auto Import is effectively end-of-lifed with Win10 (ref. https://crbug555550#c21)

I don't think it's a foregone conclusion. In issue 555550, you note that "By default AutoImport...". The policy settings let an admin control what is auto-imported. Do these not allow other things to be imported? Also, I suspect that enterprises will be migrating from IE to Chrome much more than from Edge to Chrome.

Yes policy allows to tweak that default. I guess I assumed that OEM (master_preferences) or Enterprise (policy) didn't care much about AutoImport. I can see why it matters for Enterprises who want to switch to Chrome though but then could we make AutoImport an Enterprise feature which is turned off by default unless something is explicitly requested by policy?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac09c03b9f3cc44adf71e8836f6bebabec7a61d

commit dac09c03b9f3cc44adf71e8836f6bebabec7a61d
Author: gab <gab@chromium.org>
Date: Wed Mar 22 20:00:11 2017

Update AutoImport to import nothing by default (in absence of policy and master_prefs).

As decided in conclusion of experiment https://crbug.com/555550#c114

This simplifies the code a lot, dropping all the weird defaults accrued
over the years. AutoImport is now strictly driven by policies + master_prefs.

Also deprecated the distribution entries for the import prefs which were
duplicates of the prefs:: entries... added legacy mapping in one place in code
and it then simplifies the rest of the logic (the kDistroDict is never
registered so this was somewhat of a pain).

The new code also makes it trivial to fix  issue 601697  :) -- done!
(i.e. added support for auto import of autofill form data and saved passwords
 although actual support will depend on the support of the importer
 for the imported browser -- which is the same as the support from a
 manual import).

BUG=555550,  601697 

Review-Url: https://codereview.chromium.org/2705113005
Cr-Commit-Position: refs/heads/master@{#458853}

[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/first_run/first_run.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/first_run/first_run.h
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/first_run/first_run_browsertest.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/browser/ui/browser_ui_prefs.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/common/chrome_features.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/common/chrome_features.h
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/installer/util/master_preferences.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/installer/util/master_preferences.h
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/installer/util/master_preferences_constants.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/installer/util/master_preferences_constants.h
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/chrome/installer/util/master_preferences_unittest.cc
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/dac09c03b9f3cc44adf71e8836f6bebabec7a61d/tools/metrics/actions/actions.xml

There you go enterprise team, a little bonus from my recent cleanup :)

Awesome, Gab. Thanks!

Thanks Gab! :)