Fix and re-enable blink_perf.dom on desktop platforms. |
|||||
Issue descriptionblink_perf.dom is failing on Linux, Mac, and Windows. example first failing builds: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%285%29/builds/14472 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%285%29/builds/2401 https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf%20(5)
,
Apr 8 2016
CC yukishiino, bashi, haraken (benchmark owners)
,
Apr 8 2016
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a24e10cacf4c2809e5273d12c15cd05feebbc11 commit 1a24e10cacf4c2809e5273d12c15cd05feebbc11 Author: eakuefner <eakuefner@chromium.org> Date: Fri Apr 08 04:20:29 2016 [BotHealth] Disable blink_perf.dom on win, mac, linux BUG= 601666 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1868123002 Cr-Commit-Position: refs/heads/master@{#385987} [modify] https://crrev.com/1a24e10cacf4c2809e5273d12c15cd05feebbc11/tools/perf/benchmarks/blink_perf.py
,
May 5 2016
yukishiino, bashi, haraken: blink_perf.dom is now disabled on all desktop platforms -- the full logs aren't available for the failing runs for before, but maybe it would be a good idea to try running it locally to see if it fails, (and it doesn't fail locally, try re-enabling it?)
,
May 5 2016
blink_perf.dom contains a bunch of key benchmarks. So they need to be enabled on desktop platforms.
,
Jun 30 2016
What's the status of this? We're flying blind here and I keep getting bugs with only mobile results filed. This is really critical, we've had no coverage for 3 months now.
,
Jun 30 2016
Sorry, I should have unassigned myself after disabling. The procedure here is that perf sheriffs are responsible for disabling the tests, but then it's up to the test owner to triage the breakage and reenable the benchmark. That was made unclear because I didn't unassign myself. Re-enable is in https://codereview.chromium.org/2117563002 so I'll mark this bug fixed.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/367c0f7641530f948475b3dcb530e137d6d357a8 commit 367c0f7641530f948475b3dcb530e137d6d357a8 Author: eakuefner <eakuefner@chromium.org> Date: Thu Jun 30 19:15:07 2016 [Perf] Re-enable blink_perf.dom on desktop BUG= 601666 Review-Url: https://codereview.chromium.org/2117563002 Cr-Commit-Position: refs/heads/master@{#403243} [modify] https://crrev.com/367c0f7641530f948475b3dcb530e137d6d357a8/tools/perf/benchmarks/blink_perf.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eakuefner@chromium.org
, Apr 8 2016