New issue
Advanced search Search tips

Issue 601656 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 601282
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 601108



Sign in to add a comment

Release component build broken on Windows

Project Member Reported by kbr@chromium.org, Apr 8 2016

Issue description

Building Release with component=shared_library on Windows results in the following link failure:

D:\src\chrome\src>ninja -j 200 -C out\Release chrome
ninja: Entering directory `out\Release'
[15074/20669] LINK_EMBED(DLL) webcore_shared.dll
FAILED: D:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True webcore_shared.dll "D:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper envi
ronment.x86 False link.exe /nologo /IMPLIB:webcore_shared.dll.lib /DLL /OUT:webcore_shared.dll @webcore_shared.dll.rsp" 2 mt.exe rc.exe "obj\third_party\WebKit\Source\core\webcore_shared.webcore_share
d.dll.intermediate.manifest" obj\third_party\WebKit\Source\core\webcore_shared.webcore_shared.dll.generated.manifest
webcore_shared.OriginTrials.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String>::isEmptyValue(class WTF::String const &)" (?isEmptyValue@?$H
ashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z)
webcore_shared.dll : fatal error LNK1120: 1 unresolved externals
Traceback (most recent call last):
  File "gyp-win-tool", line 315, in <module>
    sys.exit(main(sys.argv[1:]))
  File "gyp-win-tool", line 29, in main
    exit_code = executor.Dispatch(args)
  File "gyp-win-tool", line 71, in Dispatch
    return getattr(self, method)(*args[1:])
  File "gyp-win-tool", line 171, in ExecLinkWithManifests
    subprocess.check_call(ldcmd + add_to_ld)
  File "D:\src\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'D:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:webcore_shared.dll.lib /DLL /OUT:webcore_sh
ared.dll @webcore_shared.dll.rsp webcore_shared.dll.manifest.res' returned non-zero exit status 1120
[15074/20669] CXX obj\ui\message_center\views\message_center.message_list_view.obj
ninja: build stopped: subcommand failed.


This was caused by https://crrev.com/b03579678fa2678748d5cbcec2e18a8a08e40701 -- confirmed by reverting locally -- but I'm not sure how this is running successfully on the bots. I thought there would be at least one configuration building Release + component build.

mek@, do you think you could figure out why this inline function seems to be being optimized away in release builds on Windows, and why your CL is affected?

 

Comment 1 by mek@chromium.org, Apr 8 2016

See also 601282. But I have no idea what's going on here. There is no reason the very simple OriginTrials.cpp file would even need that symbol.

Comment 2 by kbr@chromium.org, Apr 8 2016

Mergedinto: 601282
Status: Duplicate (was: Assigned)

Sign in to add a comment