accelerated_video_decode gpu blacklist entry doesn't work. |
|||||
Issue descriptionEven if accelerated_video_decode is specified, the gpu is still used for video decoding. I think this was introduced by r380906. That added a new disable_accelerated_video_decode GpuPeferences flag which is set based on the browser's command line, not the GPU process's. It ignores all flags specified in GpuDataManagerImplPrivate::AppendGpuCommandLine.
,
Apr 11 2016
The fixing CL (https://codereview.chromium.org/1881463002) is ready for review.
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c commit 4c901e8f2249a4efacb311d0e24d09f3c88c8e0c Author: penghuang <penghuang@chromium.org> Date: Tue Apr 12 13:32:02 2016 Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine. GpuDataManagerImplPrivate::AppendGpuCommandLine() may add some GPU command line switches which have been replaced by GpuPreferences. So we need set those preferences in GpuDataManagerImplPrivate::AppendGpuCommandLine() to allow GPU process get the correct GpuPreferences via IPC message. BUG= 601647 Review URL: https://codereview.chromium.org/1881463002 Cr-Commit-Position: refs/heads/master@{#386669} [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_data_manager_impl.cc [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_data_manager_impl.h [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_data_manager_impl_private.h [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/4c901e8f2249a4efacb311d0e24d09f3c88c8e0c/content/browser/gpu/gpu_process_host.h
,
Apr 12 2016
,
Apr 13 2016
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd9653eced19e3ade9b042631cb8f4488bb5d834 commit dd9653eced19e3ade9b042631cb8f4488bb5d834 Author: Peng Huang <penghuang@google.com> Date: Wed Apr 13 15:13:29 2016 Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine. GpuDataManagerImplPrivate::AppendGpuCommandLine() may add some GPU command line switches which have been replaced by GpuPreferences. So we need set those preferences in GpuDataManagerImplPrivate::AppendGpuCommandLine() to allow GPU process get the correct GpuPreferences via IPC message. BUG= 601647 Review URL: https://codereview.chromium.org/1881463002 Cr-Commit-Position: refs/heads/master@{#386669} (cherry picked from commit 4c901e8f2249a4efacb311d0e24d09f3c88c8e0c) Review URL: https://codereview.chromium.org/1885023002 . Cr-Commit-Position: refs/branch-heads/2704@{#26} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_data_manager_impl.cc [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_data_manager_impl.h [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_data_manager_impl_private.h [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/dd9653eced19e3ade9b042631cb8f4488bb5d834/content/browser/gpu/gpu_process_host.h
,
Apr 13 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by penghuang@chromium.org
, Apr 8 2016