New issue
Advanced search Search tips

Issue 601633 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

can we get rid of extension_installed_bubble_view.cc::HeadingAndCloseButtonView?

Project Member Reported by est...@chromium.org, Apr 7 2016 
seems like we should be able to use GetWindowTitle, GetWindowIcon, and ShouldShowCloseButton
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f523398a2537664751d9dbb676b28ad1a081a82

commit 6f523398a2537664751d9dbb676b28ad1a081a82
Author: estade <estade@chromium.org>
Date: Thu Apr 28 00:55:58 2016

Use normal bubble header components in ExtensionInstalledBubbleView.

BUG= 601633 

Review-Url: https://codereview.chromium.org/1915123005
Cr-Commit-Position: refs/heads/master@{#390262}

[modify] https://crrev.com/6f523398a2537664751d9dbb676b28ad1a081a82/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Comment 2 by est...@chromium.org, Apr 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment