New issue
Advanced search Search tips

Issue 601583 link

Starred by 1 user
Status: Duplicate
Merged: issue 600911
Owner: ----
Closed: Apr 2016
Cc:
abodenha@chromium.org
jen...@chromium.org
msw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ChromeOS login screen shows clock/battery indicator in incorrect location on login screen

Project Member Reported by jhorwich@chromium.org, Apr 7 2016 
Version: 51.0.2701.0 - close to Cr-Commit-Position: refs/heads/master@{#385337}
OS: 8162.0.2016_04_07_1111 (test build...)

What steps will reproduce the problem?
(1) Build veyron_minnie from ChromeOS chroot
(2) Flash to device with cros flash
(3) Look at login screen

What is the expected output?
Clock, battery indicator, and keyboard type in the lower-right - so clicking it reveals the various settings options/info.

What do you see instead?
Clock, battery indicator, and keyboard type in the top-left.

This appears before Chrome renders the shelf ("Shut down" / "Browse as Guest" etc.) or the user tiles. My device has three users, and a "GB" keyboard.

Once I sign in, the clock/battery/keyboard type end up in the shelf as expected (user has shelf on bottom, not autohiding).

Also, I didn't notice this until ~1 day ago (I've been keeping my ChromeOS build fresh ~daily), so my best guess is this was introduced in the last few days.

Comment 1 by jhorwich@chromium.org, Apr 7 2016

Cc: msw@chromium.org
I think I might have found where things regressed here - I did a quick look at the git log and saw a candidate, right before I did a normal bisect.

Using simplechrome workflow:

$ export BOARD=veyron_minnie
$ cros chrome-sdk --board=$BOARD --internal

(sdk) $ unset PKG_CONFIG_PATH
(sdk) $ git checkout -b bisect_601583 5d32c4d7ac9cd3e4a45a5cc   # r385337
(sdk) $ gclient sync
(sdk) $ ninja -C out_${BOARD}/Release -j1000 chrome chrome_sandbox nacl_helper
(sdk) $ deploy_chrome --build-dir=out_${BOARD}/Release --to=minnie

Result: Clock, etc. in top left corner.

(sdk) $ git revert 174379b507800b1f
(sdk) $ ninja -C out_${BOARD}/Release -j1000 chrome chrome_sandbox nacl_helper
(sdk) $ deploy_chrome --build-dir=out_${BOARD}/Release --to=minnie

Result: Clock, etc., in bottom-right as desired.

The reverted CL corresponds to https://codereview.chromium.org/1851883002 "Cleanup shelf initialization and observation.". I'll cc the CL author in case I'm correct.

Comment 2 by jhorwich@chromium.org, Apr 7 2016

Components: UI>Shell>StartScreen

Comment 3 by abod...@chromium.org, Apr 7 2016

Mergedinto: 600911
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment