New issue
Advanced search Search tips

Issue 601555 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

[MD settings] Languages and Input title

Project Member Reported by dschuyler@chromium.org, Apr 7 2016

Issue description

In the MD section list at https://docs.google.com/spreadsheets/d/1Rvc51Ia4WKVU82KXeDH-Icj8bQcoM3GDxo6zoXiunXo/edit#gid=0
only "Languages" is listed a section name.

Should that be "Languages and Input" on chrome os and
"Languages" on other platforms -- or should it be
"Languages" on all platforms?
 
I could make a separate bug if you like, but if you don't mind another text question in the same area:

Should we say "Manage devices" or "Manage inputs"?
IMO it should be "Manage input methods".

"inputs" and "devices" are both too vague -- the Devices section handles peripherals (including the keyboard).

Comment 3 by bettes@chromium.org, Apr 20 2016

Cc: bettes@chromium.org
Owner: dschuyler@chromium.org
"Languages and input" on chrome os
"Languages" on chrome

"Manage input methods" SGTM.

Thanks!

Mocks updated
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Language.png%3Fz=width&c=show
Owner: michae...@chromium.org
Labels: Hotlist-MD-Settings-Languages
Status: Started (was: Assigned)
"Manage input methods" is done, switching to "Languages and input" on Chrome OS now.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0633a600bae31ab92c9f6975ce2e8e963a6b190

commit a0633a600bae31ab92c9f6975ce2e8e963a6b190
Author: michaelpg <michaelpg@chromium.org>
Date: Wed Jun 08 01:29:52 2016

MD Settings: Set language strings conditionally on OS

On Chrome OS, the language section should be titled "Language and input".

Also includes enclosing language strings in <if>s for strings that are
only used on certain platforms.

BUG= 601555 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2037243003
Cr-Commit-Position: refs/heads/master@{#398450}

[modify] https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/a0633a600bae31ab92c9f6975ce2e8e963a6b190/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment