New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Finish reverting dump-on-DCHECK and merge back to 2702

Project Member Reported by w...@chromium.org, Apr 7 2016

Issue description

Revert is in CQ at: https://codereview.chromium.org/1870633003/

Once it lands, we should merge to branch 2702 and push a new Canary to switch off the firehose.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c6faeb81f1461952b5c63ad33e9fccc021a0c95

commit 0c6faeb81f1461952b5c63ad33e9fccc021a0c95
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Apr 07 19:19:51 2016

Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231,  601551 

Review URL: https://codereview.chromium.org/1870633003 .

Cr-Commit-Position: refs/heads/master@{#385835}

[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/base/debug/dump_without_crashing.cc
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/base/debug/dump_without_crashing.h
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/base/logging.cc
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/base/logging.h
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/base/logging_unittest.cc
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/build/common.gypi
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/build/config/BUILD.gn
[modify] https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95/third_party/WebKit/Source/wtf/Assertions.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

Labels: merge-merged-2702
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbce535dd9db0b31583b0da338d86ee9d77f9b1e

commit fbce535dd9db0b31583b0da338d86ee9d77f9b1e
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Apr 07 19:28:45 2016

Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromium.org
BUG=596231,  601551 

Review URL: https://codereview.chromium.org/1870633003 .

Cr-Commit-Position: refs/heads/master@{#385835}
(cherry picked from commit 0c6faeb81f1461952b5c63ad33e9fccc021a0c95)

Review URL: https://codereview.chromium.org/1875443002 .

Cr-Commit-Position: refs/branch-heads/2702@{#2}
Cr-Branched-From: 208b9d3c98bb3f1612ecc7c5e4abe49f8ea75210-refs/heads/master@{#385602}

[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/base/debug/dump_without_crashing.cc
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/base/debug/dump_without_crashing.h
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/base/logging.cc
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/base/logging.h
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/base/logging_unittest.cc
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/build/common.gypi
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/build/config/BUILD.gn
[modify] https://crrev.com/fbce535dd9db0b31583b0da338d86ee9d77f9b1e/third_party/WebKit/Source/wtf/Assertions.h

Comment 3 by w...@chromium.org, Apr 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment