New issue
Advanced search Search tips

Issue 601548 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2016
Cc:
reillyg@chromium.org
mcasas@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add mojo infra initialization for Blink Source/modules unittests

Project Member Reported by mcasas@chromium.org, Apr 7 2016 
Some unit tests files might need mojo infra from
Source/modules. Such an infra is usually initialized 
from the appropriate RunAllTests.cpp, e.g.
Source/platform/testing/RunAllTests.cpp [1]

but the RunAllTests.cpp associated to Source/web 
and Source/modules, Source/web/RunAllTests.cpp, 
does not have it yet. 

[1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/testing/RunAllTests.cpp&sq=package:chromium&type=cs&q=third_party/WebKit/Source/platform/testing/RunAllTests.cpp&l=106

Comment 1 by mcasas@chromium.org, Apr 7 2016 

I stumbled upon this during [1], while migrating
the ScreenWakeLockTest.cpp: ScreenWakeLock changes
to use mojo directly, so I had to change the unit
test to provide a mojo service mock.

[1] https://codereview.chromium.org/1794553002/

Comment 2 by mcasas@chromium.org, Apr 7 2016

Cc: esprehn@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6

commit a233807cc4036b90d2cc2ca4a9e45f91d160f2b6
Author: mcasas <mcasas@chromium.org>
Date: Fri Apr 08 00:26:42 2016

Blink Source/web RunAllTests.cpp: add mojo initialization

Blink modules/ unittests will need mojo initialized
(actually, imminently in http://crrev.com/1794553002)

modules/ unittests are piggibacking on web/ tests, so
this CL adds mojo initialization there.

BUG= 601548 
TEST= all tests etc passing.

Review URL: https://codereview.chromium.org/1871753002

Cr-Commit-Position: refs/heads/master@{#385936}

[modify] https://crrev.com/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6/third_party/WebKit/Source/web/tests/DEPS
[modify] https://crrev.com/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6/third_party/WebKit/Source/web/tests/RunAllTests.cpp

Comment 4 by mcasas@chromium.org, Apr 9 2016

Status: Fixed (was: Unconfirmed)

Comment 5 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals
►

Sign in to add a comment