New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601513 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 429053
issue 599840



Sign in to add a comment

Emulate TexStorage{2|3}D on Desktop GL lower than 4.2

Project Member Reported by zmo@chromium.org, Apr 7 2016

Issue description

We can use multiple TexImage calls (one per level) with null data.
 

Comment 1 by zmo@chromium.org, Apr 7 2016

Blocking: 599840

Comment 2 by zmo@chromium.org, Apr 7 2016

Owner: zmo@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8edf606b24fe8f69becdbf0afe8ae69c16375482

commit 8edf606b24fe8f69becdbf0afe8ae69c16375482
Author: zmo <zmo@chromium.org>
Date: Tue Apr 12 04:33:14 2016

Enable TexStorage on Desktop GL lower than 4.2

On MacOSX core profile, the highest GL supported is 4.1. However, TexStorage functions are only included in 4.2 or higher.

However, it seems that most (if not all) mac drivers expose ARB_texture_storage extension, so we simply expose the GL binding when the extension exists.

This CL also consolidate similar code in handling TexStorage2D and 3D.

BUG= 601513 
TEST=gpu_unittests
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1872663002

Cr-Commit-Position: refs/heads/master@{#386586}

[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/ui/gl/generate_bindings.py
[modify] https://crrev.com/8edf606b24fe8f69becdbf0afe8ae69c16375482/ui/gl/gl_bindings_autogen_gl.cc

Comment 4 by zmo@chromium.org, Apr 12 2016

Status: Fixed (was: Started)
Components: -Internals>GPU>WebGL

Sign in to add a comment