[Media Router WebUI] Blocking issues are not dismissed properly. |
||||||||
Issue description
What steps will reproduce the problem?
(1) Open the Media Router dialog (--enable-media-router, right click + "Cast...")
(2) Paste in the JS console:
$('media-router-container').issue = new media_router.Issue('issue id 3', 'Issue Title 3', 'Issue Message 3', 0, 1, 'route id 3', true, 1234);
(3) Click "Dismiss" button.
(4)
What is the expected output?
MRUI switches back to the sink list.
What do you see instead?
Header stays on the blocking error state; nothing is shown below.
,
Apr 14 2016
,
Apr 18 2016
,
Apr 18 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 18 2016
Please merge your change to M51 branch 2704 ASAP (before 6:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8eb1fe71cc1cd9506175970a2b933f32f374449 commit f8eb1fe71cc1cd9506175970a2b933f32f374449 Author: Jennifer Apacible <apacible@google.com> Date: Mon Apr 18 21:18:54 2016 [Media Router WebUI] Switch back to sink view after blocking issue is resolved. When a blocking issue is resolved, container's |issue| is set to null. Currently, the UI doesn't switch back to the sink list view, leaving the user in a relatively blank issue view with no way of switching back. Note that blocking issues take precedence to non-blocking issues, so there is no case where a blocking issue can be replaced by a non-blocking issue. It always becomes null when it is resolved. This change also fixes an issue where the issue banner's offsetHeight is always 0. BUG= 601502 Review URL: https://codereview.chromium.org/1868983003 Cr-Commit-Position: refs/heads/master@{#387451} (cherry picked from commit fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c) Review URL: https://codereview.chromium.org/1897803003 . Cr-Commit-Position: refs/branch-heads/2704@{#112} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js
,
Apr 28 2016
Jennifer, the latest behavior when ejecting the castouts user from a hangout is an error msg but the UI has changed. It's now the grey strip at the bottom of the dialog with the dismiss button. Was it intentional to not use the red error type UI anymore? And also the new error msg says "There were not enough participants in the hangout to remain active". Chrome: 52.0.2715.0 MR: 5216.0.0
,
Apr 28 2016
I also logged b/28440539 in case #7 is an internal castouts issue. Jennifer, do you know another way to trigger this "red type" of error in MR?
,
Apr 28 2016
The type of error UI to use and messaging to show is determined from the castouts/hangouts mrp side when the issue is created. Closing this since this is being tracked in another bug.
,
Apr 28 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 14 2016