New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601502 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
no longer active
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Blocking issues are not dismissed properly.

Project Member Reported by apaci...@chromium.org, Apr 7 2016

Issue description

What steps will reproduce the problem?
(1) Open the Media Router dialog (--enable-media-router, right click + "Cast...")
(2) Paste in the JS console:
$('media-router-container').issue = new media_router.Issue('issue id 3', 'Issue Title 3', 'Issue Message 3', 0, 1, 'route id 3', true, 1234);
(3) Click "Dismiss" button.
(4) 

What is the expected output?
MRUI switches back to the sink list.

What do you see instead?
Header stays on the blocking error state; nothing is shown below.
 
Screen Shot 2016-04-07 at 9.51.38 AM.png
4.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c

commit fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c
Author: apacible <apacible@chromium.org>
Date: Thu Apr 14 22:32:54 2016

[Media Router WebUI] Switch back to sink view after blocking issue is resolved.

When a blocking issue is resolved, container's |issue| is set to null. Currently, the UI doesn't switch back to the sink list view, leaving the user in a relatively blank issue view with no way of switching back.

Note that blocking issues take precedence to non-blocking issues, so there is no case where a blocking issue can be replaced by a non-blocking issue. It always becomes null when it is resolved.

This change also fixes an issue where the issue banner's offsetHeight is always 0.

BUG= 601502 

Review URL: https://codereview.chromium.org/1868983003

Cr-Commit-Position: refs/heads/master@{#387451}

[modify] https://crrev.com/fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js

Status: Fixed (was: Assigned)
Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 18 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 by gov...@chromium.org, Apr 18 2016

Please merge your change to M51 branch 2704 ASAP (before 6:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8eb1fe71cc1cd9506175970a2b933f32f374449

commit f8eb1fe71cc1cd9506175970a2b933f32f374449
Author: Jennifer Apacible <apacible@google.com>
Date: Mon Apr 18 21:18:54 2016

[Media Router WebUI] Switch back to sink view after blocking issue is resolved.

When a blocking issue is resolved, container's |issue| is set to null. Currently, the UI doesn't switch back to the sink list view, leaving the user in a relatively blank issue view with no way of switching back.

Note that blocking issues take precedence to non-blocking issues, so there is no case where a blocking issue can be replaced by a non-blocking issue. It always becomes null when it is resolved.

This change also fixes an issue where the issue banner's offsetHeight is always 0.

BUG= 601502 

Review URL: https://codereview.chromium.org/1868983003

Cr-Commit-Position: refs/heads/master@{#387451}
(cherry picked from commit fee1baea9fdb05cb5867f46eb1ffe5c850be9d9c)

Review URL: https://codereview.chromium.org/1897803003 .

Cr-Commit-Position: refs/branch-heads/2704@{#112}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/f8eb1fe71cc1cd9506175970a2b933f32f374449/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js

Status: Available (was: Fixed)
Jennifer, the latest behavior when ejecting the castouts user from a hangout is an error msg but the UI has changed. It's now the grey strip at the bottom of the dialog with the dismiss button. Was it intentional to not use the red error type UI anymore?

And also the new error msg says "There were not enough participants in the hangout to remain active".

Chrome: 52.0.2715.0
MR: 5216.0.0
I also logged b/28440539 in case #7 is an internal castouts issue.

Jennifer, do you know another way to trigger this "red type" of error in MR?
Status: Fixed (was: Available)
The type of error UI to use and messaging to show is determined from the castouts/hangouts mrp side when the issue is created.

Closing this since this is being tracked in another bug.
Status: Verified (was: Fixed)

Sign in to add a comment