New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601470 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

WebRTC: video element onresize is not called with the correct video videoWidth/videoHeight

Reported by fi...@appear.in, Apr 7 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/49.0.2623.108 Chrome/49.0.2623.108 Safari/537.36

Steps to reproduce the problem:
1. go to https://webrtc.github.io/samples/src/content/peerconnection/pc1/
2. paste the attached JS into the console
3. make a call
4. call setBw(8)
(which reduces the bandwidth to 8kbit/s)

What is the expected behavior?
the video element's onresize handler is called with 320x240 and 160x120.

What went wrong?
the video element's onresize handler is called with videoWidth and videoHeight of 640x480 and 320x240.

The remoteVideo's videoWidth and videoHeight actually reflect the correct values so this looks like a problem with how the videoWidth and videoHeight are updated.

Did this work before? N/A 

Chrome version: 49.0.2623.108  Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by fi...@appear.in, Apr 7 2016

bandwidth.js
1.6 KB View Download
Components: Blink>WebRTC>Video
Owner: tommi@chromium.org
Status: Assigned (was: Unconfirmed)
So it looks like the updated values are not available when the onresize handler is called then.

tommi@ is this something your team could fix?


Ping

Comment 4 by tommi@chromium.org, Mar 9 2017

Owner: guidou@chromium.org
Guido - an old issue that I haven't had the time to look into.  I'm not sure this is a webrtc issue though. Maybe someone on the blink team needs to take a look?

Comment 5 by fi...@appear.in, Apr 18 2017

possibly a variation of this bug:
https://jsfiddle.net/uu6xbty0/1/
I don't expect onresize to be called twice with the same value?

Comment 6 by hta@chromium.org, Oct 20 2017

as per https://github.com/webrtc/samples/pull/935 latest update, it seems that in 63, onresize is called with the correct video size for local track when applyConstraints is used. So the delay(?) is strictly for remote tracks? Or is it fixed in 63?

Comment 7 by fi...@appear.in, Oct 20 2017

so AFAICS the original issue is gone but the "call it twice" from #5 seems to be still an issue. Close this one and see who has enough energy for a new bug?

Comment 8 by guidou@chromium.org, Oct 23 2017

Closing as per #6 and #7. Filed bug 777444 for the issue in #5

Comment 9 by guidou@chromium.org, Oct 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment