dump-without-crashing minidumps are missing the DCHECK message |
|||||
Issue descriptionExample: http://crash/094fce8400000000 Looked into the minidump (and even tried digging through it with SysInternals's strings.exe): the DCHECK message is nowhere to be found.
,
Apr 8 2016
The dump without crashing code doesn't even keep the string on the stack so yes this is an issue with the dcheck-dump code. Overall we would also like for these messages to land in a crash key of its own but that's another story.
,
Apr 9 2016
Re #2: Yes, I know the dump-on-DCHECK behaviour; I did that deliberately (though based on your feedback I'll be revising the patch in that respect). My question was which issue this bug refers to - do you have a separate bug for the crash-key integration, or do we need to file one?
,
Apr 11 2016
Ok this bug is about the first point (filled before we had similar discussion over email, feel free to handle the way you prefer). For the crash key integration there wasn't one but I just filled issue 602285 for it, thanks.
,
Apr 11 2016
,
Apr 11 2016
,
Apr 25 2016
Marking WontFix, since this behaviour matches that of CHECK, and we don't want dump-on-DCHECK to cause additional bloat of the binary. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by w...@chromium.org
, Apr 8 2016Owner: gab@chromium.org