New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601469 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 596231



Sign in to add a comment

dump-without-crashing minidumps are missing the DCHECK message

Project Member Reported by gab@chromium.org, Apr 7 2016

Issue description

Example: http://crash/094fce8400000000

Looked into the minidump (and even tried digging through it with SysInternals's strings.exe): the DCHECK message is nowhere to be found.
 

Comment 1 by w...@chromium.org, Apr 8 2016

Cc: ivanpe@chromium.org
Owner: gab@chromium.org
Is this a general problem with Windows crash uploads, or something specific to my dump-on-DCHECK?  The latter was specifically not set up to log the DCHECK text, in an effort to avoid bloating the build with those strings (as discussed offline, we'll look at leaving them in for the retry!)

Comment 2 by gab@chromium.org, Apr 8 2016

Owner: w...@chromium.org
The dump without crashing code doesn't even keep the string on the stack so yes this is an issue with the dcheck-dump code.

Overall we would also like for these messages to land in a crash key of its own but that's another story.

Comment 3 by w...@chromium.org, Apr 9 2016

Re #2: Yes, I know the dump-on-DCHECK behaviour; I did that deliberately (though based on your feedback I'll be revising the patch in that respect).

My question was which issue this bug refers to - do you have a separate bug for the crash-key integration, or do we need to file one?

Comment 4 by gab@chromium.org, Apr 11 2016

Ok this bug is about the first point (filled before we had similar discussion over email, feel free to handle the way you prefer).

For the crash key integration there wasn't one but I just filled  issue 602285  for it, thanks.

Comment 5 by w...@chromium.org, Apr 11 2016

Labels: -Pri-2 Pri-3

Comment 6 by w...@chromium.org, Apr 11 2016

Blocking: 596231

Comment 7 by w...@chromium.org, Apr 25 2016

Status: WontFix (was: Assigned)
Marking WontFix, since this behaviour matches that of CHECK, and we don't want dump-on-DCHECK to cause additional bloat of the binary.

Sign in to add a comment