New issue
Advanced search Search tips

Issue 601468 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Speed up v8 test runner by making sure slow tests always run first

Project Member Reported by machenb...@chromium.org, Apr 7 2016

Issue description

The V8 status file allows to mark tests as SLOW. Those will be scheduled first to avoid unnecessary prolonging if randomly scheduled in the end.

Currently there is no overview over which tests are how slow on which builder. Also, if a manual clean up was done at some time, it happens often later that new slow tests get checked in without being marked slow.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9025b5ac8db7455400dd8707cdc64e500abb8088

commit 9025b5ac8db7455400dd8707cdc64e500abb8088
Author: machenbach <machenbach@chromium.org>
Date: Fri Apr 08 12:11:20 2016

[test] Report more test duration data.

This will allow the infrastructure to warn about new very
slow tests which are not marked as slow. If not marked, they
might be scheduled late in the test run and prolong the
overall running time uselessly.

BUG=chromium:601468
LOG=n

Review URL: https://codereview.chromium.org/1863793005

Cr-Commit-Position: refs/heads/master@{#35356}

[modify] https://crrev.com/9025b5ac8db7455400dd8707cdc64e500abb8088/tools/testrunner/local/progress.py

Comment 3 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>V8
Labels: -Infra-Client-V8

Comment 4 by benhenry@google.com, Jun 27 2016

Status: Assigned (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6e376b6c5b573ea755578eda681fb7eda5758cb3

commit 6e376b6c5b573ea755578eda681fb7eda5758cb3
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 15 12:05:12 2017

[test] Mark slow tests

Mark slow tests discovered by manual audit of reported durations.

Slow tests will run first, which will lead to higher test runner throughput.

Also some tests have flaky timeouts occasionally.

BUG=chromium:601468

Change-Id: If9aeb5422e79ff25b867b01c50386a5fdebeb494
Reviewed-on: https://chromium-review.googlesource.com/455736
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43819}
[modify] https://crrev.com/6e376b6c5b573ea755578eda681fb7eda5758cb3/test/cctest/cctest.status
[modify] https://crrev.com/6e376b6c5b573ea755578eda681fb7eda5758cb3/test/debugger/debugger.status
[modify] https://crrev.com/6e376b6c5b573ea755578eda681fb7eda5758cb3/test/mjsunit/mjsunit.status
[modify] https://crrev.com/6e376b6c5b573ea755578eda681fb7eda5758cb3/test/test262/test262.status

Sign in to add a comment