Missing TRACE_STR_COPY in cc/scheduler/begin_frame_tracker.cc |
||||||
Issue descriptionWhile revieweing https://codereview.chromium.org/1870563002/ I noticed that begin_frame_tracker.cc, which was introduced by https://codereview.chromium.org/787763006, is passing const char* pointers to TRACE_EVENT macros derived from a member variable, without using TRACE_STR_COPY. That will cause tracing to crash / derefernce invalid pointers if the BeginFrameTracker object goes out of scope before tracing. I think that code is missing a TRACE_STR_COPY.
,
Apr 8 2016
,
Apr 8 2016
Sunny, could you please triage this?
,
Apr 12 2016
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c289ed1dff66e6d902c6d7e46aac5926fb52ded8 commit c289ed1dff66e6d902c6d7e46aac5926fb52ded8 Author: sunnyps <sunnyps@chromium.org> Date: Fri Apr 22 18:35:10 2016 cc: Copy arg names for tracing in BeginFrameTracker. Tracing does not copy arg names by default assuming them to be global constants. BeginFrameTracker passes the location string to tracing but does not copy them leading to a crash later. BUG= 601459 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1876413003 Cr-Commit-Position: refs/heads/master@{#389179} [modify] https://crrev.com/c289ed1dff66e6d902c6d7e46aac5926fb52ded8/cc/scheduler/begin_frame_tracker.cc
,
Jun 28 2016
,
Feb 2 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by primiano@chromium.org
, Apr 8 2016