New issue
Advanced search Search tips

Issue 601433 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"FeedbackTest.ShowFeedback" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 7 2016

Issue description

"FeedbackTest.ShowFeedback" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJAsSBUZsYWtlIhlGZWVkYmFja1Rlc3QuU2hvd0ZlZWRiYWNrDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 Deleted

This is probably related to crbug/601306.
Owner: r...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/764b849cf6d041cd31a335af6d5ee055f15d7567

commit 764b849cf6d041cd31a335af6d5ee055f15d7567
Author: magjed <magjed@chromium.org>
Date: Thu Apr 07 14:07:32 2016

Disable flaky FeedbackTest.ShowFeedback on Chrome OS

BUG= 601433 
TBR=rkc
NOTRY=true

Review URL: https://codereview.chromium.org/1865323002

Cr-Commit-Position: refs/heads/master@{#385747}

[modify] https://crrev.com/764b849cf6d041cd31a335af6d5ee055f15d7567/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc

Cc: steve...@chromium.org xiy...@chromium.org r...@chromium.org achuith@chromium.org
 Issue 601308  has been merged into this issue.
Owner: m...@chromium.org
The feedback extension is taking a screenshot via screen capture.[1]

[1]: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/feedback/js/take_screenshot.js&l=32

This now triggers a DCHECK added in https://codereview.chromium.org/1864813002

miu@, could you take a look?

Comment 8 by jam@chromium.org, Apr 7 2016

This is also flaking LoginFeedbackTest.Basic
Sample failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/13267/steps/browser_tests%20on%20Ubuntu-12.04/logs/FeedbackTest.ShowLoginFeedback

[20766:20934:0407/002341:FATAL:aura_window_capture_machine.cc(127)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::UI). Must be called on Chrome_UIThread; actually called on AudioThread.
#0 0x7f32f67e715e base::debug::StackTrace::StackTrace()
#1 0x7f32f683d80c logging::LogMessage::~LogMessage()
#2 0x7f32f1a7a061 content::AuraWindowCaptureMachine::MaybeCaptureForRefresh()
#3 0x7f32ed5ef406 media::ScreenCaptureDeviceCore::RequestRefreshFrame()
#4 0x7f32f1a7ed31 content::DesktopCaptureDeviceAura::RequestRefreshFrame()
#5 0x7f32f0785e29 _ZN4base8internal15RunnableAdapterIMNS_18CancelableCallbackIFvvEEEKFvvEE3RunIJEEEvPKS4_DpOT_
#6 0x7f32f0bf4a89 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN7content22GeolocationServiceImplEFvvEEEE8MakeItSoIJPS4_EEEvS7_DpOT_
#7 0x7f32f1002bcd _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN5media18VideoCaptureDeviceEFvvEEEFvPS7_EJNS0_17UnretainedWrapperIS7_EEEEENS0_12InvokeHelperILb0EvSA_EEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x7f32f67cf0fe base::Callback<>::Run()
#9 0x7f32f67ec01e base::debug::TaskAnnotator::RunTask()
#10 0x7f32f68588d1 base::MessageLoop::RunTask()
#11 0x7f32f6858b58 base::MessageLoop::DeferOrRunPendingTask()
#12 0x7f32f6858d22 base::MessageLoop::DoWork()
#13 0x7f32f6868814 base::MessagePumpDefault::Run()
#14 0x7f32f685834a base::MessageLoop::RunHandler()
#15 0x7f32f68d28b4 base::RunLoop::Run()
#16 0x7f32f6857621 base::MessageLoop::Run()
#17 0x7f32f694cf59 base::Thread::Run()
#18 0x7f32f694d28d base::Thread::ThreadMain()
#19 0x7f32f693a54a base::(anonymous namespace)::ThreadFunc()
#20 0x7f32e1bbee9a start_thread
#21 0x7f32df76e38d clone


Comment 10 by m...@chromium.org, Apr 7 2016

Status: Fixed (was: Assigned)
Fixed by: https://codereview.chromium.org/1871663002/

I've kicked off a revert of the unit test that was disabled in #c4: https://codereview.chromium.org/1872613002/
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c2a89c96aee23f0d1561cf9b3b0416effa3e96

commit b0c2a89c96aee23f0d1561cf9b3b0416effa3e96
Author: miu <miu@chromium.org>
Date: Thu Apr 07 21:53:43 2016

Revert of Disable flaky FeedbackTest.ShowFeedback on Chrome OS (patchset #1 id:1 of https://codereview.chromium.org/1865323002/ )

Reason for revert:
Issue now fixed (https://codereview.chromium.org/1871663002/).

Original issue's description:
> Disable flaky FeedbackTest.ShowFeedback on Chrome OS
>
> BUG= 601433 
> TBR=rkc
> NOTRY=true
>
> Committed: https://crrev.com/764b849cf6d041cd31a335af6d5ee055f15d7567
> Cr-Commit-Position: refs/heads/master@{#385747}

TBR=rkc@chromium.org,beaudoin@chromium.org,magjed@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 601433 

Review URL: https://codereview.chromium.org/1872613002

Cr-Commit-Position: refs/heads/master@{#385887}

[modify] https://crrev.com/b0c2a89c96aee23f0d1561cf9b3b0416effa3e96/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc

Sign in to add a comment