New issue
Advanced search Search tips

Issue 601407 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Composited transform Web Animation with neutral keyframe animates incorrectly

Project Member Reported by alancutter@chromium.org, Apr 7 2016

Issue description

Test case: https://jsfiddle.net/LL6k3w76/
Requires experimental features enabled.
The Web Animation is out of sync with the other animations.
If you disable composited animations (--disable-threaded-animation) then all three animate in sync.
 
Labels: -Type-Bug Type-Feature
Looks like this is because compositor animations only support keyframe easing and not animation easing.

Not sure why it only occurs when neutral keyframes are used though. Here's a test case that includes non-neutral Web Animations: https://jsfiddle.net/LL6k3w76/1/
Labels: -Type-Feature Type-Bug
The compositor supports animation easing, the problem is the default easing for keyframes is "ease" while that's not the case for Web Animations.
The out of sync animation actually has "ease" applied twice.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d5466b3824d1170c02088d7c38e2ca1e53c95b

commit 99d5466b3824d1170c02088d7c38e2ca1e53c95b
Author: alancutter <alancutter@chromium.org>
Date: Fri Apr 15 04:51:39 2016

Use "linear" as the default easing for neutral keyframes in element.animate()

By explicitly setting "linear" as the default keyframe easing when using
element.animate() we don't accidentally start compositor animations
using their default of "ease".

BUG= 601407 

Review URL: https://codereview.chromium.org/1866153003

Cr-Commit-Position: refs/heads/master@{#387537}

[add] https://crrev.com/99d5466b3824d1170c02088d7c38e2ca1e53c95b/third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing-expected.html
[add] https://crrev.com/99d5466b3824d1170c02088d7c38e2ca1e53c95b/third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing.html
[modify] https://crrev.com/99d5466b3824d1170c02088d7c38e2ca1e53c95b/third_party/WebKit/Source/core/animation/EffectInput.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment