run_webkit_tests causes /tmp/.org.chromium.Chromium.XXXXX directories to be created but doesn't clean them up. |
||||
Issue descriptionAfter 30 runs of run_webkit_tests I have ended up with 8671 of these temporary directories. drwx------ 5 tansell eng 4096 Apr 7 16:21 .org.chromium.Chromium.ZtBTk0 drwx------ 4 tansell eng 4096 Apr 7 15:49 .org.chromium.Chromium.zTIp56 drwx------ 5 tansell eng 4096 Apr 7 15:28 .org.chromium.Chromium.ZTj6ck drwx------ 4 tansell eng 4096 Apr 7 17:06 .org.chromium.Chromium.ZtJOXU drwx------ 5 tansell eng 4096 Apr 7 15:56 .org.chromium.Chromium.ZTlhHn drwx------ 4 tansell eng 4096 Apr 7 18:41 .org.chromium.Chromium.ztm2KT drwx------ 4 tansell eng 4096 Apr 7 18:41 .org.chromium.Chromium.ZtXmYi drwx------ 4 tansell eng 4096 Apr 6 17:24 .org.chromium.Chromium.ZUCzAp drwx------ 3 tansell eng 4096 Apr 7 17:13 .org.chromium.Chromium.zUDiNp drwx------ 4 tansell eng 4096 Apr 7 15:53 .org.chromium.Chromium.ZUF2gF drwx------ 4 tansell eng 4096 Apr 7 18:52 .org.chromium.Chromium.zUrjEi drwx------ 5 tansell eng 4096 Apr 7 17:24 .org.chromium.Chromium.zUVEOC drwx------ 4 tansell eng 4096 Apr 1 15:03 .org.chromium.Chromium.ZV6ban drwx------ 4 tansell eng 4096 Apr 7 17:49 .org.chromium.Chromium.ZVAoPH drwx------ 3 tansell eng 4096 Apr 7 16:38 .org.chromium.Chromium.ZVBxME drwx------ 9 tansell eng 4096 Apr 7 17:06 .org.chromium.Chromium.zvFhR0 drwx------ 4 tansell eng 4096 Apr 7 17:28 .org.chromium.Chromium.zVMiQI drwx------ 3 tansell eng 4096 Apr 7 18:03 .org.chromium.Chromium.zvmYBl
,
May 3 2016
This seems like it might be caused by mkdtemp in webkitpy/common/system/filesystem.py. According to https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py#138, this will not delete the temporary directory if the temporary directory is not empty. There's a comment in the code with a question: should we clean up non-empty directories? Looks like the answer may be yes. To verify that this is the issue, we could: 1. Run run-webkit-tests again and verify that this is still an issue 2. Change mkdtemp to clean up non-empty directories and see if run-webkit-tests is still leaving behind temp directories. If it stops leaving behind temp directories then, the question is whether is should be emptying the directory somewhere else, and whether it should clean up non-empty directories all the time anyway.
,
Mar 22 2017
Bug update: I wasn't able to reproduce this on my workstation.
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
Closing based on comment 3, since this was last repro'd two years ago. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sshru...@google.com
, Apr 18 2016