New issue
Advanced search Search tips

Issue 601355 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

microdump_stackwalk broken in GN builds (symlinks to dump_syms instead)

Project Member Reported by primiano@chromium.org, Apr 7 2016

Issue description

I ninja microdump_stackwalk but I get dump_syms instead:

This is my gn config:
is_component_build = false
is_debug = false
dcheck_always_on = true
use_goma = true
goma_dir = "/usr/local/google/home/primiano/tools/goma"
enable_nacl = false
target_os = "android"

The ./obj/breakpad/microdump_stackwalk.ninja is clearly wrong:
rule __breakpad_microdump_stackwalk___build_toolchain_android_arm__rule
  command = python ../../build/symlink.py -f clang_x64/dump_syms microdump_stackwalk

It is not clear to me from the gn rules why microdump_stackwalk ends up being symlinked to dump_syms. 
 
Owner: primiano@chromium.org
Status: Started (was: Untriaged)
Ok I think I found it.
Mind taking a look to https://codereview.chromium.org/1866933002/ ?

Btw, this should have been caught by breakpad_unittests? I assume they are not running on bots in gn builds at this point? 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383

commit 4ecbb21114b83df4830c3d1dc7d4b8491b1b0383
Author: primiano <primiano@chromium.org>
Date: Thu Apr 07 13:27:23 2016

breakpad: fix GN build files for microdump_stackwalk

Some copy/paste error was causing breakpad executables like
microdump_stackwalk to be symlinked against dump_syms, which
is unrelated

BUG= 601355 
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1866933002

Cr-Commit-Position: refs/heads/master@{#385738}

[modify] https://crrev.com/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383/breakpad/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment