microdump_stackwalk broken in GN builds (symlinks to dump_syms instead) |
||
Issue descriptionI ninja microdump_stackwalk but I get dump_syms instead: This is my gn config: is_component_build = false is_debug = false dcheck_always_on = true use_goma = true goma_dir = "/usr/local/google/home/primiano/tools/goma" enable_nacl = false target_os = "android" The ./obj/breakpad/microdump_stackwalk.ninja is clearly wrong: rule __breakpad_microdump_stackwalk___build_toolchain_android_arm__rule command = python ../../build/symlink.py -f clang_x64/dump_syms microdump_stackwalk It is not clear to me from the gn rules why microdump_stackwalk ends up being symlinked to dump_syms.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383 commit 4ecbb21114b83df4830c3d1dc7d4b8491b1b0383 Author: primiano <primiano@chromium.org> Date: Thu Apr 07 13:27:23 2016 breakpad: fix GN build files for microdump_stackwalk Some copy/paste error was causing breakpad executables like microdump_stackwalk to be symlinked against dump_syms, which is unrelated BUG= 601355 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1866933002 Cr-Commit-Position: refs/heads/master@{#385738} [modify] https://crrev.com/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383/breakpad/BUILD.gn
,
Apr 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by primiano@chromium.org
, Apr 7 2016Status: Started (was: Untriaged)