New issue
Advanced search Search tips

Issue 601310 link

Starred by 1 user
Status: Fixed
Owner:
elijahtaylor@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ARC runtime can be disabled by policy even if ARC apps are installed by policy

Project Member Reported by elijahtaylor@chromium.org, Apr 7 2016 
I suspect this is caused by some blanket blacklisting, but it's possible for the runtime to be disabled, thus keeping ARC apps from launching.

One solution is to prevent shared modules (which are just resource collections) from being disabled ever.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c09c5cdf77a9f8380ce78b0e450006e22110f6

commit 49c09c5cdf77a9f8380ce78b0e450006e22110f6
Author: elijahtaylor <elijahtaylor@chromium.org>
Date: Sat Jul 09 01:06:22 2016

Make sure Shared Modules cannot be disabled

BUG= 601310 , 620091 
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart

Review-Url: https://codereview.chromium.org/2131173003
Cr-Commit-Position: refs/heads/master@{#404554}

[modify] https://crrev.com/49c09c5cdf77a9f8380ce78b0e450006e22110f6/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/49c09c5cdf77a9f8380ce78b0e450006e22110f6/chrome/browser/extensions/extension_service_unittest.cc

Comment 2 by elijahtaylor@chromium.org, Jul 11 2016

Labels: Merge-Request-53 M-53
requesting merge to M53 so enterprises (schools) coming back in September don't run into this bug

Comment 3 by dimu@google.com, Jul 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01925b7fc8a584580e564f8ad2c2f96a2e96441e

commit 01925b7fc8a584580e564f8ad2c2f96a2e96441e
Author: Elijah Taylor <elijahtaylor@google.com>
Date: Mon Jul 11 19:31:54 2016

Make sure Shared Modules cannot be disabled

BUG= 601310 , 620091 
TEST=ExtensionServiceTest.CannotDisableSharedModules
TEST=manually disable shared module in preferences, start chrome and observe
     shared module is enabled on restart

Review-Url: https://codereview.chromium.org/2131173003
Cr-Commit-Position: refs/heads/master@{#404554}
(cherry picked from commit 49c09c5cdf77a9f8380ce78b0e450006e22110f6)

Review URL: https://codereview.chromium.org/2136173002 .

Cr-Commit-Position: refs/branch-heads/2785@{#89}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/01925b7fc8a584580e564f8ad2c2f96a2e96441e/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/01925b7fc8a584580e564f8ad2c2f96a2e96441e/chrome/browser/extensions/extension_service_unittest.cc

Comment 5 by elijahtaylor@chromium.org, Aug 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment