New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601307 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 521730
Owner:
Last visit 16 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 303728



Sign in to add a comment

Mark two layout tests as failing on WebKit Win10

Project Member Reported by loyso@chromium.org, Apr 7 2016

Issue description

Regressions: Unexpected image-only failures (2)
  printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]
  virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html [ Failure ]

Regressions: Unexpected missing results (12)
  printing/absolute-position-headers-and-footers.html [ Missing ]
  printing/fixed-positioned-but-static-headers-and-footers.html [ Missing ]
  printing/fixed-positioned-headers-and-footers-clipped.html [ Missing ]
  printing/fixed-positioned-headers-and-footers-inside-transform.html [ Missing ]
  printing/fixed-positioned-headers-and-footers-larger-than-page.html [ Missing ]
  printing/fixed-positioned-headers-and-footers.html [ Missing ]
  virtual/threaded/printing/absolute-position-headers-and-footers.html [ Missing ]
  virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers.html [ Missing ]
  virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped.html [ Missing ]
  virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform.html [ Missing ]
  virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page.html [ Missing ]
  virtual/threaded/printing/fixed-positioned-headers-and-footers.html [ Missing ]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7427a70a0972bb194af13a78e5c3a276f1a8a04b

commit 7427a70a0972bb194af13a78e5c3a276f1a8a04b
Author: loyso <loyso@chromium.org>
Date: Thu Apr 07 05:38:31 2016

Disable broken printing layout tests.

BUG= 601307 
TBR=wangxianzhu@chromium.org
TBR=robhogan@gmail.com
NOTRY=true

Review URL: https://codereview.chromium.org/1863383002

Cr-Commit-Position: refs/heads/master@{#385672}

[modify] https://crrev.com/7427a70a0972bb194af13a78e5c3a276f1a8a04b/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by loyso@chromium.org, Apr 7 2016

Labels: Sheriff-Chromium
It needs Win10 specific results but rebaseline doesn't currently allow that. Is anyone planning to fix that? This is going to keep biting people and there's no alternative but to mark the tests as failing until someone does.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4013bf2398ff2752e5355fc2e64e7123063a63

commit 7f4013bf2398ff2752e5355fc2e64e7123063a63
Author: magjed <magjed@chromium.org>
Date: Thu Apr 07 12:42:15 2016

Disable broken printing layout tests on Win 10

This is a follow-up to https://codereview.chromium.org/1863383002/. The
tests fail with 'Missing', not 'Failing'.

BUG= 601307 
TBR=wangxianzhu@chromium.org
TBR=robhogan@gmail.com
NOTRY=true

Review URL: https://codereview.chromium.org/1868993002

Cr-Commit-Position: refs/heads/master@{#385729}

[modify] https://crrev.com/7f4013bf2398ff2752e5355fc2e64e7123063a63/third_party/WebKit/LayoutTests/TestExpectations

Owner: robhogan@chromium.org
The failing WebKit Win10 bot is here:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10

The CL that introduced the problem was 'Auto-rebaseline for r385513' here:
https://codereview.chromium.org/1867663002

robhogan - Do you know how to fix Auto-rebaseline to include Win 10 results or at least mark the test for Win 10 as 'Missing'?
No. However you should just mark these two as failing and put them in with  crbug.com/521730  in TestExpectations. That is the bug tracking the eventual addition of Win10 specific results for all tests that require them.
Owner: magjed@chromium.org
Summary: Mark two layout tests as failing on WebKit Win10 (was: Printing layout tests are broken on WebKit Win10)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e94fbefb04e1c9f133e5d1773476590fdeef009

commit 2e94fbefb04e1c9f133e5d1773476590fdeef009
Author: robhogan <robhogan@gmail.com>
Date: Fri Apr 08 07:20:44 2016

Win10 failures need Win10 specific results, add as failing for now.

TBR=eae@chromium.org

BUG= 521730 , 303728 , 601307 

Review URL: https://codereview.chromium.org/1870023002

Cr-Commit-Position: refs/heads/master@{#386014}

[modify] https://crrev.com/2e94fbefb04e1c9f133e5d1773476590fdeef009/third_party/WebKit/LayoutTests/TestExpectations

Mergedinto: 521730
Status: Duplicate (was: Available)

Sign in to add a comment