New issue
Advanced search Search tips

Issue 601306 link

Starred by 0 users
Status: Fixed
Owner:
m...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"FeedbackTest.ShowLoginFeedback" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 7 2016 
"FeedbackTest.ShowLoginFeedback" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5GZWVkYmFja1Rlc3QuU2hvd0xvZ2luRmVlZGJhY2sM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by magjed@chromium.org, Apr 7 2016 

 Issue 601309  has been merged into this issue.

Comment 2 by magjed@chromium.org, Apr 7 2016

Owner: r...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac516a0acc5863cb988937194d645928cc4871a

commit eac516a0acc5863cb988937194d645928cc4871a
Author: magjed <magjed@chromium.org>
Date: Thu Apr 07 14:08:25 2016

Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS

BUG= 601306 
TBR=rkc
NOTRY=true

Review URL: https://codereview.chromium.org/1859363005

Cr-Commit-Position: refs/heads/master@{#385748}

[modify] https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc

Comment 4 by m...@chromium.org, Apr 7 2016

Owner: m...@chromium.org
Status: Fixed (was: Assigned)
Fixed by: https://codereview.chromium.org/1871663002/

I've kicked off a revert of the unit test that was disabled in #c3: https://codereview.chromium.org/1869143003/
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b2f15deeed56d7f1765a170eeb8c663cf481f0

commit c9b2f15deeed56d7f1765a170eeb8c663cf481f0
Author: miu <miu@chromium.org>
Date: Thu Apr 07 21:56:37 2016

Revert of Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS (patchset #1 id:1 of https://codereview.chromium.org/1859363005/ )

Reason for revert:
Fixed by: https://codereview.chromium.org/1871663002/

Original issue's description:
> Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS
>
> BUG= 601306 
> TBR=rkc
> NOTRY=true
>
> Committed: https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a
> Cr-Commit-Position: refs/heads/master@{#385748}

TBR=rkc@chromium.org,beaudoin@chromium.org,magjed@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 601306 

Review URL: https://codereview.chromium.org/1869143003

Cr-Commit-Position: refs/heads/master@{#385889}

[modify] https://crrev.com/c9b2f15deeed56d7f1765a170eeb8c663cf481f0/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc
►

Sign in to add a comment