New issue
Advanced search Search tips

Issue 601293 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make Times New Roman canShapeWordbyWord when kerning is enabled

Project Member Reported by kojii@chromium.org, Apr 7 2016

Issue description

Currently Times New Roman on Windows has m_canShapeWordByWord=false if kerning is enabled.

This is because Times New Roman has kerning with space in its Hebrew table.  Firefox does canShapeWordByWord determination per script to solve this.

Moreover, Firefox, if optimizeLegibility is NOT set and font size is small enough, ignores the kerning-with-space and still uses the cache.
 

Comment 1 by drott@chromium.org, May 4 2016

A preliminary architectural idea would be:

Move the CachingWordShapeIterator nextWordEnd logic into its own CachingWordShaping segmenter, similar to ScriptRunIterator. 

Then have a new segmenter combining ScriptRunIterator and this one, and return the next word end index and the next script.

Then check canShapeByWord(script).

Comment 2 by kojii@chromium.org, May 4 2016

Agree that ScriptRunIterator needs to run first.

I'm wondering, is it possible to merge the two segmentation layers into one. I mean, currently we do:
  caching-word segmentation -> cache -> multiple segmentations -> shaping
we could do:
  script & caching-word -> cache -> other segmentations -> shaping
but can we do:
  all segmentations -> cache -> shaping
?

Is there a reason for other segmentation than script done after caching?

Comment 3 by drott@chromium.org, May 23 2016

Performance perhaps - the segmentation before caching should be as fast as possible. After that, additional segmentation is needed to split runs into something that HarfBuzz can digest. But we can certainly experiment.
Project Member

Comment 4 by sheriffbot@chromium.org, May 23 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by drott@chromium.org, May 24 2017

Status: Available (was: Untriaged)
Project Member

Comment 6 by sheriffbot@chromium.org, May 24 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by kojii@chromium.org, May 25 2018

Status: WontFix (was: Untriaged)
With LayoutNG approaching, I don't think we should worry about this any longer.

Comment 8 by drott@chromium.org, May 30 2018

I'd prefer to keep this open. We can close it once we move to LayoutNG, wdyt?

Sign in to add a comment