Issue metadata
Sign in to add a comment
|
With the latest chromite, chrome-sdk no longer shows colored shell |
||||||||||||||||||||||
Issue description<b>Version: <Kenneth, what is the frequency?></b> <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (0) Update ~/chrome/src/DEPS to roll chromite to the latest revision (It hasn't been rolled for 9 months!). (1) cd ~/chrome/src (2) cros chrome-sdk --board=$BOARD What is the expected output? Seeing shell colored yellow. What do you see instead? White shell. Please use labels and text to provide additional information. According to git bisect: c5e1e32f4014be9bb0dc455e7589964568347968 is the first bad commit commit c5e1e32f4014be9bb0dc455e7589964568347968 Author: Mike Frysinger <vapier@chromium.org> Date: Thu Jul 30 10:45:40 2015 -0400 chrome-sdk: re-use existing PS1 for shell Rather than create a custom PS1 that people aren't use to, try and extract the value the user has set up already. This should hopefully provide a more familiar environment. BUG= chromium:295110 TEST=`cros chrome-sdk` re-used my custom PS1 Change-Id: Ia3ba0abe8b55c45469ca956413470b26682e07a2 Reviewed-on: https://chromium-review.googlesource.com/289760 Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
,
Apr 7 2016
In issue 295110 , it's said "It's good to realize when you are in an sdk shell vs. not." and I totally agree with it. Because a number of comments were deleted from the issue, I'm still not sure why the change was made. How about providing the color setting by default?
,
Apr 7 2016
any @chromium.org user can click the "show deleted comments" link. you'll see that they're irrelevant to the discussion ... just metadata updates. as for "It's good to realize when you are in an sdk shell vs. not", that behavior is still retained -- we insert the details to the start of $PS1 and leave the user's PS1 alone otherwise. as for the color, we could change the leading details, but that's it. the rest of the prompt *is your prompt* so if you want color, you should configure it in your system. reverting the CL or changing it to (once again) insert arbitrary colors isn't an option or desirable.
,
Apr 8 2016
Sorry, I still don't understand why issue 295110 whose summary says "chrome-sdk should use PS1 colors like the chromeos chroot" was marked as fixed with a change which makes the prompt uncolored. Does that mean we are also to make chromeos chroot (cros_sdk) uncolored?
,
Apr 8 2016
i've changed the summary of issue 295110 to match the direction we went |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, Apr 7 2016Owner: vapier@chromium.org
Status: WontFix (was: Available)