New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601264 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Stop extension icon animation when dragging a tab between windows

Project Member Reported by shrike@chromium.org, Apr 7 2016

Issue description


What steps will reproduce the problem?
(1) Load up your toolbar with extensions
(2) Drag a tab out of a browser window

What is the expected output?
The extension icons should not move at all as I drag the window out.

What do you see instead?
Upon dragging the window out the extension icons animate into the extension area from the left.


 
Labels: Hotlist-Polish
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a583e6115fec107f2d4a1cffa69d5f572d89a57

commit 5a583e6115fec107f2d4a1cffa69d5f572d89a57
Author: shrike <shrike@chromium.org>
Date: Fri Apr 08 16:33:19 2016

[Mac] Prevent extension icon animation when window not visible.

When you drag a tab out of its window the extension icons animate into
position even though it should appear that the tab and its controls
are being removed as-is from their window. This makes the tab dragging
effect look klunky and unpolished.

R=avi@chromium.org
BUG= 601264 

Review URL: https://codereview.chromium.org/1862243006

Cr-Commit-Position: refs/heads/master@{#386096}

[modify] https://crrev.com/5a583e6115fec107f2d4a1cffa69d5f572d89a57/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment