DevTools: Service workers upload on reload / redundant |
||||
Issue descriptionFew observations on issues we might want to fix: 1) Redundant list grows, but is empty on DevTools reopen we might want to clear the redundant entries once service worker from the same scope / with the same URL was loaded as active. 2) If I have "upload on load" checked and go from a good SW to the one that fails install, I still have an active one. we should make sure that active SW is kicked out and developer gets the error state.
,
Apr 7 2016
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acbebdd456ad518ca697c2436d3ccd53c3649cef commit acbebdd456ad518ca697c2436d3ccd53c3649cef Author: pfeldman <pfeldman@chromium.org> Date: Thu Apr 07 07:40:35 2016 DevTools: display recent SW revisions on top of the list, remove stale redundant ones. BUG= 601263 Review URL: https://codereview.chromium.org/1862123004 Cr-Commit-Position: refs/heads/master@{#385689} [modify] https://crrev.com/acbebdd456ad518ca697c2436d3ccd53c3649cef/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
,
Apr 8 2016
More investigation notes after talking to dgozman@: - Instead of updating the SW upon reload, we should update the SW's script on reload. I.e. we recreate the dedicated worker inside SW, retain Active version in present registration. Then we reload the page and let SW control it. - Rename Delete to Unregister - Introduce a new checkbox "Bypass SW" next to update on reload.
,
Apr 8 2016
,
Apr 8 2016
>> - Instead of updating the SW upon reload, we should update the SW's script on reload. I.e. we recreate the dedicated worker inside SW, retain Active version in present registration. Then we reload the page and let SW control it. @horo: could you do that?
,
Apr 8 2016
Sorry, I don't understand what "recreate the dedicated worker inside SW" means. I think we should execute 'install' and 'activate' event handlers while the page reload if "upload on load" is checked. ServiceWorker downloads the static content of the site in the install event handler from the server to the CacheStorage. And it deletes the old data in the activate event handler. https://codelabs.developers.google.com/codelabs/your-first-pwapp/#5 While the developers reload the page with "upload on load", they want the CacheStorage to be updated.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c93539131ee3c12548ba833e688dc872773b5f49 commit c93539131ee3c12548ba833e688dc872773b5f49 Author: pfeldman <pfeldman@chromium.org> Date: Tue Apr 19 20:22:40 2016 DevTools: introduce the bypass service worker checkbox. BUG= 601263 Review URL: https://codereview.chromium.org/1872673002 Cr-Commit-Position: refs/heads/master@{#388296} [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js [modify] https://crrev.com/c93539131ee3c12548ba833e688dc872773b5f49/third_party/WebKit/Source/devtools/protocol.json
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99df79c37fd3e0ccaf2aa992acb44d3cd1a7c27 commit a99df79c37fd3e0ccaf2aa992acb44d3cd1a7c27 Author: horo <horo@chromium.org> Date: Wed Apr 20 12:05:17 2016 Don't stop ServiceWorker when DevTools is attached even if JS execution is failed. BUG= 601263 Review URL: https://codereview.chromium.org/1901363002 Cr-Commit-Position: refs/heads/master@{#388469} [modify] https://crrev.com/a99df79c37fd3e0ccaf2aa992acb44d3cd1a7c27/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/a99df79c37fd3e0ccaf2aa992acb44d3cd1a7c27/content/browser/service_worker/service_worker_version.h
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3afce45806e538c59e51fe46bf392477a044414b commit 3afce45806e538c59e51fe46bf392477a044414b Author: horo <horo@chromium.org> Date: Fri Apr 22 01:00:01 2016 DevTools: Attach all Service Workers except for old redundant workers. DevTools will attach all SWs in best mathcing scopes. But redundant workers will be detached when new worker is installed. BUG= 601263 Review URL: https://codereview.chromium.org/1893313007 Cr-Commit-Position: refs/heads/master@{#388987} [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/protocol/service_worker_handler.h [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/devtools/service_worker_devtools_manager.h [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/service_worker/embedded_worker_instance.h [modify] https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b/content/browser/service_worker/service_worker_version.cc
,
Jun 20 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pfeldman@chromium.org
, Apr 7 2016