Detected 4 new flakes for test/step "Patch". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEAsSBUZsYWtlIgVQYXRjaAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

This shouldn't really be reported to the Sheriff-Chromium label IMO - it should just be ignored.

Same goes with all the "(with patch)" steps. If a test fail with the engineer's patch applied, it doesn't really tell anything about the flakiness of that test.

Some "(with patch)" bugs that was auto-filed: 
 bug 601281 
 bug 601266 
 bug 599776 
 bug 596730 

+sergiyb = can you report Patch step to troopers at all times? It's not the same as "with patch", though Henrik's comment #3 is totally valid, IMO.

+sergiyb@
Also, this https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEAsSBUZsYWtlIgVQYXRjaAw groups all purple and red failures together, which is wrong. Red failures are likely not rebased patches, which has nothing to do with flakes. 

As for purple part of this bug, here is fix:
https://codereview.chromium.org/1876093002/

Re #4, please see https://codereview.chromium.org/1881443002.
Re #5, we already handle this by ignoring flakes where failed run happens after success run, please see https://chromium.googlesource.com/infra/infra/+/master/appengine/chromium_try_flakes/handlers/flake_issues.py#524.

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3df7b5c58d2b73b0449d10f2b7ba2fdc167a3e51

commit 3df7b5c58d2b73b0449d10f2b7ba2fdc167a3e51
Author: sergiyb <sergiyb@chromium.org>
Date: Mon Apr 11 15:15:35 2016

Fix step name to the normalized version

R=tandrii@chromium.org
BUG= 601260 

Review URL: https://codereview.chromium.org/1881443002

[modify] https://crrev.com/3df7b5c58d2b73b0449d10f2b7ba2fdc167a3e51/appengine/chromium_try_flakes/handlers/flake_issues.py

I think patch is flaky issue is fixed, but assigning to sergiyb@ for followup separation of red and purple (infra)  patch application failures.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/432fb944228eb01764c530f8052baffbe6585be6

commit 432fb944228eb01764c530f8052baffbe6585be6
Author: tandrii@chromium.org <tandrii@chromium.org>
Date: Mon Apr 11 17:29:46 2016

rietveld: retry more transient errors.

Namely these errors when applying patch:

  <urlopen error [Errno 10060] A connection attempt failed
  because the connected party did not properly respond after
  a period of time, or established connection failed because
  connected host has failed to respond>

  <urlopen error [Errno 104] Connection reset by peer>

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG= 601260 

Review URL: https://codereview.chromium.org/1876093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299837 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/432fb944228eb01764c530f8052baffbe6585be6/rietveld.py

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/45fae6019b4d4982b9a3fc50fcf5addf91ff2abe

commit 45fae6019b4d4982b9a3fc50fcf5addf91ff2abe
Author: sergiyb <sergiyb@chromium.org>
Date: Mon Apr 11 18:46:58 2016

Only report Patch failure on infra error and refactor code

R=tandrii@chromium.org
BUG= 601260 

Review URL: https://codereview.chromium.org/1873243002

[modify] https://crrev.com/45fae6019b4d4982b9a3fc50fcf5addf91ff2abe/appengine/chromium_try_flakes/handlers/flake_issues.py
[modify] https://crrev.com/45fae6019b4d4982b9a3fc50fcf5addf91ff2abe/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/92a7e3be67587626fb3267a2395a074efa520d90

commit 92a7e3be67587626fb3267a2395a074efa520d90
Author: sergiyb <sergiyb@chromium.org>
Date: Thu Apr 14 14:04:43 2016

Remove debugging code

TBR=tandrii@chromium.org
BUG= 601260 

Review URL: https://codereview.chromium.org/1890863002

[modify] https://crrev.com/92a7e3be67587626fb3267a2395a074efa520d90/appengine/chromium_try_flakes/handlers/flake_issues.py

I'm reopening this because it looks like the retry added in 432fb944228eb01764c530f8052baffbe6585be6 might not be working as expected. 

Connecting to https://codereview.chromium.org
Downloading patch from https://codereview.chromium.org/2482213003/#ps10001
ERROR apply_issue( 252): Failed to fetch the patch for issue 2482213003, patchset 10001
Traceback (most recent call last):
  File "E:\b\depot_tools\\apply_issue.py", line 239, in main
    patchset = rietveld_obj.get_patch(issue_to_apply, patchset_to_apply)
  File "E:\b\depot_tools\rietveld.py", line 167, in get_patch
    diff = self.get_file_diff(issue, patchset, state['id'])
  File "E:\b\depot_tools\rietveld.py", line 126, in get_file_diff
    return self.get(url)
  File "E:\b\depot_tools\rietveld.py", line 397, in get
    return self._send(request_path, **kwargs)
  File "E:\b\depot_tools\rietveld.py", line 426, in _send
    return self.rpc_server.Send(request_path, **kwargs)
  File "E:\b\depot_tools\third_party\upload.py", line 457, in Send
    f = self.opener.open(req, timeout=70)
  File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 404, in open
    response = self._open(req, data)
  File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 422, in _open
    '_open', req)
  File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 1222, in https_open
    return self.do_open(httplib.HTTPSConnection, req)
  File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 1184, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond>

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/328333/steps/bot_update/logs/patch%20error
https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_chromium_rel_ng/328333

	sergiyb@, are you able to look into this?

Sorry, I get too many updates from the issue tracker, so this issue has somehow slipped between the cracks. Looking at the build, the step is correctly marked as infra. Andrii, can you please have a look why your fix does not work?

Derp, this is totally my bad. Fix: https://chromium-review.googlesource.com/415147

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/1bf69a1245fe1fbd9af896560e3b96a63f48a67b

commit 1bf69a1245fe1fbd9af896560e3b96a63f48a67b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Nov 29 17:26:23 2016

Fix bug in is_transient check of rietveld rpc errors.

R=katthomas@chromium.org,sergiyb@chromium.org
BUG= chromium:601260 

Change-Id: I79e1e807d1f8aed8d294742974d1f42a852c6b13
Reviewed-on: https://chromium-review.googlesource.com/415147
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/1bf69a1245fe1fbd9af896560e3b96a63f48a67b/rietveld.py