New issue
Advanced search Search tips

Issue 601254 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The net predictor should use ResourceThrottles to track requests

Project Member Reported by csharrison@chromium.org, Apr 6 2016

Issue description

Right now we inject into ChromeNetworkDelegate methods to track URLRequests and referrers, but it would be better to isolate this logic into a ResourceThrottle.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0f401524eb0009f583f8bb63959115013bf1a4

commit cb0f401524eb0009f583f8bb63959115013bf1a4
Author: csharrison <csharrison@chromium.org>
Date: Wed Jun 01 00:13:09 2016

Refactor net predictor to use ResourceThrottles

The predictor currently hooks into ChromeNetworkDelegate for callbacks.
This patch reduces the number of moving parts by attaching a throttle for
resources coming into the RDHD.

BUG= 601254 

Review-Url: https://codereview.chromium.org/1857383002
Cr-Commit-Position: refs/heads/master@{#396988}

[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/io_thread.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/net/chrome_network_delegate.h
[delete] https://crrev.com/f146e750697e48b4cc8305dd6a692cced1c27ffe/chrome/browser/net/connect_interceptor.cc
[delete] https://crrev.com/f146e750697e48b4cc8305dd6a692cced1c27ffe/chrome/browser/net/connect_interceptor.h
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/net/predictor.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/net/predictor.h
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
[add] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/renderer_host/predictor_resource_throttle.cc
[add] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/browser/renderer_host/predictor_resource_throttle.h
[modify] https://crrev.com/cb0f401524eb0009f583f8bb63959115013bf1a4/chrome/chrome_browser.gypi

Status: Fixed (was: Started)

Sign in to add a comment