New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601249 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Extensions keep selected state when moved out from overflow to toolbar (OSX MD-topchrome)

Project Member Reported by ainslie@chromium.org, Apr 6 2016

Issue description

OSX with MD top chrome. 
Version 51.0.2700.0 canary (64-bit)

- start with an extension overflowed into wrench menu
- open wrench menu
- right click an extension 
- it'll pop out onto the toolbar with a selected state and context menu open
- click in the content area
- the context menu dismisses but the selected state highlight stays visible


 
just-selected-state.png
27.8 KB View Download
context-menu-shown.png
50.8 KB View Download
Cc: -shrike@chromium.org rdevlin....@chromium.org
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)
I am not quite able to reproduce this - perhaps I am missing a step.

If I control-click the extension in the menu I don't get the contextual menu. Instead I get the extension's bubble. But sometimes if I dismiss the bubble the icon is left highlighted.

I also found that if I place an extension in the menu and control-click it it comes out and I get its contextual menu. If I choose to keep it in the toolbar it stays there but also remains highlighted.

Labels: Proj-MaterialDesign-NativeUI
Cc: -rdevlin....@chromium.org shrike@chromium.org
Components: Platform>Extensions
Owner: rdevlin....@chromium.org
I've been able to repro and written a fix while investigating another bug.  I'll snag this one from you, if that's okay. :)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3a55f8fe3980f561aaba28e1a593d7ad020653b

commit e3a55f8fe3980f561aaba28e1a593d7ad020653b
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Apr 14 19:16:40 2016

[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG= 601249 

Review URL: https://codereview.chromium.org/1888133002

Cr-Commit-Position: refs/heads/master@{#387389}

[modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button.h
[modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

Cc: ainslie@chromium.org
Status: Fixed (was: Assigned)
This should be fixed (it no longer repros for me locally).  ainslie@, in a day or so when this is in Canary, can you verify?

Sign in to add a comment