Extensions keep selected state when moved out from overflow to toolbar (OSX MD-topchrome) |
||||
Issue descriptionOSX with MD top chrome. Version 51.0.2700.0 canary (64-bit) - start with an extension overflowed into wrench menu - open wrench menu - right click an extension - it'll pop out onto the toolbar with a selected state and context menu open - click in the content area - the context menu dismisses but the selected state highlight stays visible
,
Apr 11 2016
,
Apr 14 2016
I've been able to repro and written a fix while investigating another bug. I'll snag this one from you, if that's okay. :)
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3a55f8fe3980f561aaba28e1a593d7ad020653b commit e3a55f8fe3980f561aaba28e1a593d7ad020653b Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 14 19:16:40 2016 [Extensions UI Mac] Fix a bug with popped out actions' highlighted state Fix a bug where popped out actions wouldn't clear their highlighted state and add a couple of tests to protect against regression. BUG= 601249 Review URL: https://codereview.chromium.org/1888133002 Cr-Commit-Position: refs/heads/master@{#387389} [modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button.h [modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button.mm [modify] https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
,
Apr 14 2016
This should be fixed (it no longer repros for me locally). ainslie@, in a day or so when this is in Canary, can you verify? |
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, Apr 7 2016Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)