New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601247 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 638807



Sign in to add a comment

Scalable media player controls and Accessibility updates

Project Member Reported by rolfe@chromium.org, Apr 6 2016

Issue description

ktam - could you (or anyone who might know) help me figure out who could own the desktop equivalent of this? Marking the bug as all platforms for now.

UI Review approved the following changes to the default Chrome media player:
- Add three-dot overflow icon to menu as the width narrows. Additional items (full screen, cast, etc.) move into this overflow as space allows.
- Darken buffered amount from #9A9A9A to #5A5A5A (for Accessibility)
- Darken volume background scrubber from #9A9A9A to #5A5A5A (for Accessibility)

(Google-only links below)
UI Review thread
https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/XLb5fQUoZmE
Preview/Spec
https://drive.google.com/a/google.com/file/d/0B-Vmdj5n-YddX2RpeHlqbzZRbzg/view?usp=sharing
Assets
https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinEeHlSSEd0dE9uUDQ&usp=sharing

Questions for Chrome eng when this gets assigned:
1) Can the overflow menu open wider/taller than the media element? The preview shows how we might not be wider but we could be taller. What are the limitations?
2) Say when you start scrubbing the other controls go away and the player scrubber bit takes up the full width of the toolbar. What's the expected hours of work to make that happen? Is there any eng interest in doing that? (I know it's not a top-priority and would be a lot of work.) Curious for thoughts/ideas there.
3) There's a related thread on adding CC/Subtitles to the player. (https://bugs.chromium.org/p/chromium/issues/detail?id=495851) Not sure how to get eng aligned there but note this bug and that one overlap so toolbar work could conflict. It would be good to reach out to those eng to make sure things happen smoothly together.

 

Comment 1 by rolfe@chromium.org, Apr 6 2016

Related media bug (to add a download button to the standalone player)
https://bugs.chromium.org/p/chromium/issues/detail?id=590043

Comment 2 by rolfe@chromium.org, Apr 6 2016

Cc: rolfe@chromium.org

Comment 3 by k...@chromium.org, Apr 12 2016

I chatted with Min and it sounds like the code will by-in-large the same for desktop as mobile so I assume whoever implements for mobile will implement for both.

Additionally - sounds like we can open an overflow menu that's larger than the media element.

Frank mentioned that this project shouldn't be too difficult given the controls are already mostly responsive. It's just a matter of getting the overflow to show up. Most likely we'd be targeting M53 and it's just a matter of eng prioritization.
Status: Assigned (was: Untriaged)

Comment 5 by rolfe@chromium.org, Apr 13 2016

Awesome news on the overflow sizing!
Cc: rachelis@chromium.org mlamouri@chromium.org

Comment 7 by k...@chromium.org, Jul 28 2016

Owner: mlamouri@chromium.org
Re-assigning to Mounir. We are targeting M55 currently.
Components: -UI -Internals>Media>UI Blink>Media>Controls
Labels: M-55
Owner: ----
Status: Available (was: Assigned)
Labels: Needs-BlinkMediaTriage

Comment 10 by k...@chromium.org, Aug 16 2016

Cc: dah...@chromium.org k...@chromium.org
 Issue 637932  has been merged into this issue.
Labels: -Pri-2 -Needs-BlinkMediaTriage Pri-1
Owner: kdsilva@google.com

Comment 12 by k...@chromium.org, Aug 18 2016

Blocking: 638807
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f6b3de90a660387f17278e1f99684f5ddacaca

commit c9f6b3de90a660387f17278e1f99684f5ddacaca
Author: kdsilva <kdsilva@google.com>
Date: Mon Sep 12 12:12:53 2016

Adding overflow menu to media player.

Adding an overflow menu makes the media player more scalable to support additional actions and features.

BUG= 601247 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2243473002
Cr-Commit-Position: refs/heads/master@{#417921}

[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/content/app/strings/content_strings.grd
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/content/child/blink_platform_impl.cc
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html
[delete] https://crrev.com/0b9dcddfc4a1d86477af180879a8a9089d7bfa6d/third_party/WebKit/LayoutTests/media/media-controls-play-button-visible.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/overflow-menu.js
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/track/cue-style-invalidation.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-appears-when-expected.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-closed-captions-button.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-last-button-visible.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-mute-button.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-play-button.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-visibility.html
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/css/CSSValueKeywords.in
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/css/mediaControlsNew.css
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/paint/MediaControlsPainter.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/Source/platform/ThemeTypes.h
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/public/blink_image_resources.grd
[add] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overflow_menu.png
[modify] https://crrev.com/c9f6b3de90a660387f17278e1f99684f5ddacaca/third_party/WebKit/public/platform/WebLocalizedString.h

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e04446d8dd30ead9e3e10f755a6becfedb03d8df

commit e04446d8dd30ead9e3e10f755a6becfedb03d8df
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Sep 12 12:15:11 2016

MediaControls Accessibility: update sliders grey color to a darker shade.

The volume bar's grey and the buffered amount from the scrubber are
switching from 9c9c9c to 5a5a5a.

BUG= 601247 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2314403004
Cr-Commit-Position: refs/heads/master@{#417922}

[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/LayoutTests/platform/mac-mac10.9/media/video-zoom-controls-expected.png
[modify] https://crrev.com/e04446d8dd30ead9e3e10f755a6becfedb03d8df/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67da83f2bc4e941e994dfe8e081e0c4a7b217799

commit 67da83f2bc4e941e994dfe8e081e0c4a7b217799
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Sep 12 13:32:25 2016

Auto-rebaseline for r417921

https://chromium.googlesource.com/chromium/src/+/c9f6b3de9

BUG= 601247 
TBR=kdsilva@google.com

Review URL: https://codereview.chromium.org/2332773002 .

Cr-Commit-Position: refs/heads/master@{#417929}

[modify] https://crrev.com/67da83f2bc4e941e994dfe8e081e0c4a7b217799/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/video-zoom-controls-expected.png
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/video-zoom-controls-expected.txt
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-mac10.9/media/video-zoom-controls-expected.png
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-mac10.9/media/video-zoom-controls-expected.txt
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png
[delete] https://crrev.com/4acec96ab3e36401cdea664db1d0c8713ebe8591/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/67da83f2bc4e941e994dfe8e081e0c4a7b217799/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/67da83f2bc4e941e994dfe8e081e0c4a7b217799/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2

commit ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2
Author: kdsilva <kdsilva@google.com>
Date: Mon Sep 12 19:20:36 2016

Adding a download button to the media player controls.

This CL contains the logic behind a runtime enabled flag to display a download button for downloadable files. It does not contain the full implementation to download the media.

BUG= 601247 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2293273002
Cr-Commit-Position: refs/heads/master@{#417996}

[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/content/app/strings/content_strings.grd
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/content/child/blink_platform_impl.cc
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/overflow-menu.js
[add] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/video-controls-download-button-displayed.html
[add] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mediastream.html
[add] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/css/CSSValueKeywords.in
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/css/mediaControlsNew.css
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/paint/MediaControlsPainter.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/Source/platform/ThemeTypes.h
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/public/blink_image_resources.grd
[add] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/public/default_100_percent/blink/mediaplayer_download.png
[modify] https://crrev.com/ee3c3c6bf22c61bbf5e6be043ac20d9e8bf91ff2/third_party/WebKit/public/platform/WebLocalizedString.h

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dadcd47646c31ffc367fce0187369dfb84818773

commit dadcd47646c31ffc367fce0187369dfb84818773
Author: kdsilva <kdsilva@google.com>
Date: Wed Sep 14 12:56:09 2016

Implementation of media controls download button.

BUG= 601247 

Review-Url: https://codereview.chromium.org/2334803002
Cr-Commit-Position: refs/heads/master@{#418540}

[add] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media-expected.txt
[add] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media.html
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html
[add] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button-expected.txt
[add] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button.html
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/dadcd47646c31ffc367fce0187369dfb84818773/third_party/WebKit/public/default_100_percent/blink/mediaplayer_download.png

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4ad33831899ad35888e65ae473a27a0c817e23

commit 6c4ad33831899ad35888e65ae473a27a0c817e23
Author: kdsilva <kdsilva@google.com>
Date: Fri Sep 16 13:06:18 2016

Removing media controls download button feature flag

BUG= 601247 

Review-Url: https://codereview.chromium.org/2337013005
Cr-Commit-Position: refs/heads/master@{#419153}

[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/chrome/test/data/android/media/simple_video.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/controls-after-unload-expected.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-download-button-displayed.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-text.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4

commit d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Sep 16 14:21:57 2016

Auto-rebaseline for r419153

https://chromium.googlesource.com/chromium/src/+/6c4ad3383

BUG= 601247 
TBR=kdsilva@google.com

Review URL: https://codereview.chromium.org/2349723002 .

Cr-Commit-Position: refs/heads/master@{#419161}

[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[add] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/android/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[add] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-mute-repaint-expected.txt
[add] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[add] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/mac/media/controls-timeline-expected.txt
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/d5c18b4658f3df5c9177e7c18ae2dfb2165fd6e4/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6

commit e34a6457a83b0d60dda1ce4776e84eeee2e97aa6
Author: kdsilva <kdsilva@google.com>
Date: Fri Sep 16 16:08:20 2016

Rebaselining Win10 with media controls download button.

This CL is a follow up to https://codereview.chromium.org/2337013005

NOTRY=true
NOTREECHECKS=true

BUG= 601247 

Review-Url: https://codereview.chromium.org/2343133002
Cr-Commit-Position: refs/heads/master@{#419181}

[modify] https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9

commit 66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9
Author: kdsilva <kdsilva@google.com>
Date: Fri Sep 16 17:10:26 2016

Reordering media controls to match the new spec.

BUG= 601247 

Review-Url: https://codereview.chromium.org/2301823002
Cr-Commit-Position: refs/heads/master@{#419196}

[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/controls-cast-button.html
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/overflow-menu.js
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html
[modify] https://crrev.com/66090fb3f2d49b3a4bcadb4d6aa09d7d9eafa7b9/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Status: Fixed (was: Available)
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Could anyone please let us know is there any manual repro steps available to verify this issue from Chrome-Te end.
Labels: -Needs-Feedback
If you go to a page like http://mounirlamouri.github.io/sandbox/media-focus.html and use the devtools to change the size of the 'html5 video', you should see an overflow menu showing up with the hidden buttons.

Also, some colour have changed. The page should demonstrate that (the buffered amount colour and the volume scrubber background have a darker grey).
Labels: TE-Verified-55.0.2868.0 TE-Verified-M55
Tested this issue on Widows-10, Mac OS 10.11.6 and Ubuntu 14.04 using chrome latest Dev #55.0.2868.0 by followings steps mentioned in the comment #27.
Compared the same with chrome stable version #53.0.2785.116 and observed there is some color changes in controls and the hidden buttons are displayed displayed on this version as expected. Hence adding TE-Verified label.
HTML5.mp4
5.9 MB View Download
Chrome Stable.png
252 KB View Download
Chrome Dev.png
225 KB View Download

Sign in to add a comment