New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601233 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 306672



Sign in to add a comment

Remove people search from the launcher

Project Member Reported by abodenha@chromium.org, Apr 6 2016

Issue description

Data shows that 0% of users are using people search in the launcher. We should yank it.
 
Cc: kuscher@chromium.org
Components: Platform>Apps>Launcher
Labels: -Type-Bug Type-Feature

Comment 2 by dymp...@gmail.com, Apr 7 2016

We would if it actually searched in contacts.google.com. I believe it did for a while and that it's supposed to, however it's been broken for a very long time.

Attached is a screenshot for my son's name. It doesn't even show a link to his G+ nor his Hangouts info.


Screenshot 2016-04-07 at 7.17.36 PM.png
18.0 KB View Download
Blocking: 306672
The feature broke as the result of a server side issue, but even before the breakage it doesn't look as though anyone was using it. So much so that it broke and no one noticed.

We have a few options:
1: Invest in it to figure out what it would take to get people using it.
2: Fix the server issue and add tests to prevent future breakage.
3: Kill it.

We discussed it internally. Summary
Given the number and importance of other things we could do with that effort #1 doesn't make sense right now. #2 also doesn't make sense; why fix something that wont see use?

So that leaves #3.

Comment 5 by dymp...@gmail.com, Apr 8 2016

Umm we did notice but...I agree with #3, there are many more important issues.
Owner: xiaoyinh@chromium.org
xiaoyinh@ can you take this one on? Talk to glevin@ about how to do it.

Comment 7 by glevin@chromium.org, Apr 26 2016

Cc: r...@chromium.org glevin@chromium.org
Just so we're on the same page, this is the main class we're talking about removing, right?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/app_list/search/people/people_result.h

+rkc@ , the original code author

Comment 8 by r...@chromium.org, Apr 26 2016

Quite a few changes were made to support people search, that is one of the classes. Please look at this CL https://chromiumcodereview.appspot.com/23874015 to get an idea of what all we might want to get rid of and revert and what we'd want to keep.

Is there a piece of this feature that is still working? That could help later to tell whether it's been removed or not.
 
Status: Started (was: Assigned)
Start looking into it.

Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1333573b1f5535417caa9e4d41ba2872cf14e9cd

commit 1333573b1f5535417caa9e4d41ba2872cf14e9cd
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Tue May 03 17:17:21 2016

Remove people search

BUG= 601233 

Review-Url: https://codereview.chromium.org/1925733005
Cr-Commit-Position: refs/heads/master@{#391276}

[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/app/generated_resources.grd
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/chat.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/chat_hover.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/chat_pressed.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/mail.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/mail_hover.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_100_percent/common/mail_pressed.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/chat.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/chat_hover.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/chat_pressed.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/mail.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/mail_hover.png
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/app/theme/default_200_percent/common/mail_pressed.png
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/app/theme/theme_resources.grd
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/people_provider.cc
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/people_provider.h
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/people_result.cc
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/people_result.h
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/person.cc
[delete] https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1/chrome/browser/ui/app_list/search/people/person.h
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/browser/ui/app_list/search/search_util.h
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/chrome/chrome_tests.gypi
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/tools/metrics/actions/actions.xml
[modify] https://crrev.com/1333573b1f5535417caa9e4d41ba2872cf14e9cd/ui/app_list/search/mixer_unittest.cc

Status: Fixed (was: Started)
First CL: Remove people search
Second CL: Remove HangoutsPrivate 
Cc: abodenha@chromium.org joshwoodward@chromium.org
 Issue 306672  has been merged into this issue.
Labels: VerifyIn-55
Status: Verified (was: Fixed)

Sign in to add a comment