Issue 601230 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	mbarbe...@chromium.org
Closed:	Apr 2016
Cc:	sergeyu@chromium.org █ mart...@martijnc.be tsepez@chromium.org mbarbe...@chromium.org infe...@chromium.org och...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

IPC fuzzer compile failure

Project Member Reported by mbarbe...@chromium.org, Apr 6 2016

Issue description

Seems to be caused by https://codereview.chromium.org/1853643007/

To reproduce, build ipc_fuzzer_all with GYP_DEFINES=enable_ipc_fuzzer=1

In file included from ../../tools/ipc_fuzzer/message_tools/message_list.cc:15:
In file included from ../../tools/ipc_fuzzer/message_lib/all_messages.h:29:
In file included from ../../remoting/host/chromoting_messages.h:13:
../../remoting/host/chromoting_param_traits.h:70:8: error: redefinition of 'IPC::ParamTraits<net::IPAddress>'
struct ParamTraits<net::IPAddress> {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../content/public/common/common_param_traits.h:78:23: note: previous definition is here
struct CONTENT_EXPORT ParamTraits<net::IPAddress> {
                      ^
In file included from ../../tools/ipc_fuzzer/message_tools/message_list.cc:15:
In file included from ../../tools/ipc_fuzzer/message_lib/all_messages.h:29:
In file included from ../../remoting/host/chromoting_messages.h:13:
../../remoting/host/chromoting_param_traits.h:80:8: error: redefinition of 'IPC::ParamTraits<net::IPEndPoint>'
struct ParamTraits<net::IPEndPoint> {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../content/public/common/common_param_traits.h:68:23: note: previous definition is here
struct CONTENT_EXPORT ParamTraits<net::IPEndPoint> {
                      ^
2 errors generated.

Comment 1 by w...@chromium.org, Apr 6 2016

Cc: sergeyu@chromium.org
Owner: mbarbe...@chromium.org

Looks like the fuzzer tool is trying to pull in both Chrome & Chromoting host's IPC messages & traits, and link into a single binary, which is something that ever happens in production binaries.

Is there just a single IPC fuzzer binary for the whole of Chrome?

If so then could we break it into one for most of Chrome, and a separate binary to fuzz just remoting/ stuff?

Comment 2 by mbarbe...@chromium.org, Apr 6 2016

Cc: tsepez@chromium.org

Yeah, there's just one IPC fuzzer binary for all of chrome.

We could have a separate binary for remoting/, but it seems like it would be nontrivial (and I wouldn't have time to implement it in the near future). Losing coverage in this area in the meantime doesn't sound ideal.

I can remove the remoting messages fairly easily to fix the failure and file another bug if that's the plan.

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee4c666d965f2782391ab3f3e2fbb5ae69d836f8

commit ee4c666d965f2782391ab3f3e2fbb5ae69d836f8
Author: mbarbella <mbarbella@chromium.org>
Date: Thu Apr 07 06:09:08 2016

Remove remoting messages from the IPC fuzzer.

R=inferno@chromium.org
BUG= 601230 

Review URL: https://codereview.chromium.org/1865163002

Cr-Commit-Position: refs/heads/master@{#385676}

[modify] https://crrev.com/ee4c666d965f2782391ab3f3e2fbb5ae69d836f8/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/ee4c666d965f2782391ab3f3e2fbb5ae69d836f8/tools/ipc_fuzzer/message_lib/all_messages.h

Comment 4 by mbarbe...@chromium.org, Apr 7 2016

Status: Fixed (was: Assigned)

►

Issue 601230 link

Issue metadata

IPC fuzzer compile failure

Issue description

Comment 1 by w...@chromium.org, Apr 6 2016

Comment 1 Deleted

Comment 2 by mbarbe...@chromium.org, Apr 6 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 7 2016

Comment 3 Deleted

Comment 4 by mbarbe...@chromium.org, Apr 7 2016

Comment 4 Deleted

Sign in to add a comment