New issue
Advanced search Search tips

Issue 601228 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add support for Gerrit to cr-rev.appspot.com

Project Member Reported by andyb...@chromium.org, Apr 6 2016

Issue description

current usage of crrev: crrev.com/<svn revision, git commit position, git sha, rietvled issue>

It should also take Gerrit issues as well.


 

Comment 1 by aga...@chromium.org, Apr 27 2016

Components: Infra>Codereview
Labels: -Infra-Codereview
Labels: Proj-Gerrit-Migration
Labels: Milestone-Dogfood
Owner: ----
Status: Available (was: Assigned)
Note that gerrit reviews look like this: https://chromium-review.googlesource.com/c/392366/

That's a six-digit number, which corresponds to an SVN revision: crrev.com/392366 -> https://chromium.googlesource.com/chromium/src/+/e9f5f0c1aa477afc87c4c42004d6f5f1077048fa

If we're going to support this, we're going to need
a) A good story for how to disambiguate those, and I think
b) A total revamp of the indexing/redirecting system.

Comment 5 by aga...@chromium.org, Jan 12 2017

Labels: -Milestone-Dogfood Milestone-Launch
Issue 709114 has been merged into this issue.
Owner: aga...@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/470167/
Status: Fixed (was: Started)
Deployed. The short urls are "crrev.com/c/N" for chromium-review and "crrev.com/i/N" for chrome-internal-review.

Sign in to add a comment