Add support for Gerrit to cr-rev.appspot.com |
||||||
Issue descriptioncurrent usage of crrev: crrev.com/<svn revision, git commit position, git sha, rietvled issue> It should also take Gerrit issues as well.
,
Jun 14 2016
,
Sep 27 2016
,
Oct 5 2016
Note that gerrit reviews look like this: https://chromium-review.googlesource.com/c/392366/ That's a six-digit number, which corresponds to an SVN revision: crrev.com/392366 -> https://chromium.googlesource.com/chromium/src/+/e9f5f0c1aa477afc87c4c42004d6f5f1077048fa If we're going to support this, we're going to need a) A good story for how to disambiguate those, and I think b) A total revamp of the indexing/redirecting system.
,
Jan 12 2017
,
Apr 6 2017
Issue 709114 has been merged into this issue.
,
Apr 6 2017
https://chromium-review.googlesource.com/c/470167/
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0a779b0c04441a0d04cb0abf985780e674e0c666 commit 0a779b0c04441a0d04cb0abf985780e674e0c666 Author: Aaron Gable <agable@chromium.org> Date: Thu Apr 06 22:47:35 2017 Add gerrit support to cr-rev Bug: 601228 Change-Id: I1b6220ec2f329a8c422cdb4fd019f0b204285b44 Reviewed-on: https://chromium-review.googlesource.com/470167 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/0a779b0c04441a0d04cb0abf985780e674e0c666/appengine/cr_rev/appengine_module/cr_rev/test/controller_test.py [modify] https://crrev.com/0a779b0c04441a0d04cb0abf985780e674e0c666/appengine/cr_rev/appengine_module/cr_rev/models.py [modify] https://crrev.com/0a779b0c04441a0d04cb0abf985780e674e0c666/appengine/cr_rev/appengine_module/cr_rev/controller.py
,
Apr 6 2017
Deployed. The short urls are "crrev.com/c/N" for chromium-review and "crrev.com/i/N" for chrome-internal-review. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aga...@chromium.org
, Apr 27 2016Labels: -Infra-Codereview