[MD Settings] Replace paper-menu usage with paper-listbox. |
|||||
Issue descriptionpaper-menu was designed to have sub-menus and brings in unnecessary complexity for the case where no sub-menus exist. See discussion at following links. https://github.com/PolymerElements/paper-listbox/issues/7 https://github.com/PolymerElements/paper-menu/issues/70 https://github.com/PolymerElements/paper-menu/issues/83 MD History seems to have already done that, see https://codereview.chromium.org/1849133002.
,
Apr 14 2016
,
Apr 14 2016
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a46787976d0cddf54793b2561e258a7c940e79 commit 67a46787976d0cddf54793b2561e258a7c940e79 Author: dpapad <dpapad@chromium.org> Date: Fri Apr 15 01:21:13 2016 MD Settings: Replace paper-menu with paper-listbox in a few places. BUG= 601214 Review URL: https://codereview.chromium.org/1891963002 Cr-Commit-Position: refs/heads/master@{#387510} [modify] https://crrev.com/67a46787976d0cddf54793b2561e258a7c940e79/chrome/browser/resources/settings/controls/settings_dropdown_menu.html [modify] https://crrev.com/67a46787976d0cddf54793b2561e258a7c940e79/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/67a46787976d0cddf54793b2561e258a7c940e79/chrome/test/data/webui/settings/dropdown_menu_tests.js
,
Apr 20 2016
@finnur: The only remaining paper-menu references in MD Settings are in site_settings/ subfolder. At first glance it seems that paper-submenu is also used, so most likely those are not replace-able by paper-listbox. Could you please verify this?
,
Apr 26 2016
site_list.html is the only reference I see under site_settings (after your CL) and it uses a paper-submenu, yes. I don't know if it can be converted into something else. Might be possible, but I don't have much time to invest in it at the moment.
,
Apr 26 2016
Closing. The only remaining paper-menu instances are actually using submenus, so they can't be converted to paper-listbox. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbuck...@chromium.org
, Apr 12 2016