New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601208 link

Starred by 1 user
Status: Fixed
Merged: issue 596659
Owner:
dpa...@chromium.org
Closed: Apr 2016
Cc:
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clear Browsing Data dialog, does not wait for clearing to be done.

Project Member Reported by dpa...@chromium.org, Apr 6 2016 
I am filing this bug to keep track of the issue that was mentioned at https://codereview.chromium.org/1750873002/diff/100001/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js#newcode102.

Pasting from that CL comment below:

"My recollection from using this UI surface in the old Options UI, is that it can take a significant amount of time to clear data, and there is a spinner showing until things are actually cleared. So, I don't think we should be closing the dialog and then starting the cleanup process, instead we should cleanup and once done (signified by a promise) we should be closing the dialog.

That requires of tweaking how 'performClearBrowserData' is implemented in C++ and use cr.sendWithPromise() instead of chrome.send."

Comment 1 by dschuyler@chromium.org, Apr 6 2016

Mergedinto: 596659
Owner: dschuyler@chromium.org
Status: Duplicate (was: Untriaged)

Comment 2 by dpa...@chromium.org, Apr 18 2016

Owner: dpa...@chromium.org
Status: Assigned (was: Duplicate)
Re-opening this bug. The specifics on how to display progress and what should be disabled while waiting is mentioned at https://bugs.chromium.org/p/chromium/issues/detail?id=596659#c6.

Comment 3 by dpa...@chromium.org, Apr 18 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44197c803294b7dbe668672c31fc01be76934961

commit 44197c803294b7dbe668672c31fc01be76934961
Author: dpapad <dpapad@chromium.org>
Date: Tue Apr 19 03:48:42 2016

MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Modifying 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI event instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG= 601208 

Review URL: https://codereview.chromium.org/1899853004

Cr-Commit-Position: refs/heads/master@{#388129}

[add] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html
[add] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/44197c803294b7dbe668672c31fc01be76934961/chrome/test/data/webui/settings/privacy_page_test.js

Comment 6 by dpa...@chromium.org, Apr 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment