New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601207 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add "Cast..." menu item to OSX top menu.

Project Member Reported by apaci...@chromium.org, Apr 6 2016

Issue description

Adding another entry point for Media Router. This will be found under "File" and positioned immediately below "Print...".
 
Status: Assigned (was: Untriaged)
Similar to the "Print..." menu item, this should be disabled if no browser windows are open.

Comment 2 by sko...@chromium.org, Apr 20 2016

Labels: -M-51 M-52

Comment 3 by mfo...@chromium.org, May 10 2016

Is this an a11y blocker?
No, this is a 'nice to have' feature.

Comment 5 by mfo...@chromium.org, May 12 2016

Labels: Hotlist-Polish

Comment 6 by mfo...@chromium.org, May 12 2016

Cc: mfo...@chromium.org

Comment 7 by sko...@chromium.org, May 27 2016

Labels: -M-52 M-53
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-54
Cc: apaci...@chromium.org
Owner: taku...@chromium.org
Note: We already have UI review approval to add the menu item.
Note 2: Someone from chrome-mac-dev@ should be a reviewer for the CL that implements this.

erikchen@ recommended two approaches: editing MainMenu.xib with XCode 5.1.1 (menu item is added statically), or using NSMenu APIs (added dynamically). Since we want to show the menu item only if MR is enabled, the latter approach will probably work better.
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996eb9a468745d8f4af72cf7da57876c51886ae2

commit 996eb9a468745d8f4af72cf7da57876c51886ae2
Author: takumif <takumif@chromium.org>
Date: Mon Nov 14 20:35:38 2016

Add "Cast..." menu item to macOS menu bar

The "Cast..." item is added in the Files section, right under "Print...".
Its functionality is equivalent to the Cast option in the hotdog menu: it opens
a Media Router dialog, is disabled when we already have a dialog open, and is
not shown when Media Router is disabled.

BUG= 601207 

Review-Url: https://codereview.chromium.org/2475433006
Cr-Commit-Position: refs/heads/master@{#431914}

[modify] https://crrev.com/996eb9a468745d8f4af72cf7da57876c51886ae2/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/996eb9a468745d8f4af72cf7da57876c51886ae2/chrome/browser/ui/cocoa/browser_window_command_handler.mm

Status: Fixed (was: Started)
Cc: shrike@chromium.org
takumif@ - please send me a link to the UI approval you mention in c#11. Adding this after Print... at first glance seems strange but maybe it makes sense.

Jennifer, do you have the link to the UI approval?

Comment 17 Deleted

(signed into wrong email, repost)

shrike@ - I'm forwarding an email to you.
Cc: pschaffner@chromium.org tapted@chromium.org pinkerton@chromium.org
 Issue 609491  has been merged into this issue.

Sign in to add a comment