New issue
Advanced search Search tips

Issue 601195 link

Starred by 1 user
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

gn: Angle does not declare dependency between common/version.h and id/commit.h.

Project Member Reported by jbroman@chromium.org, Apr 6 2016 
This causes gn check issues.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/06feb81cb628b81393471fc3430f2fc893226e74

commit 06feb81cb628b81393471fc3430f2fc893226e74
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Apr 06 20:39:52 2016

Make :angle_common depend on :commit_id.

BUG= chromium:601195 
Change-Id: Ic90b8c8dbe07700e66c8fe973a3e620f439d2fbe
Reviewed-on: https://chromium-review.googlesource.com/337335
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/06feb81cb628b81393471fc3430f2fc893226e74/BUILD.gn
[modify] https://crrev.com/06feb81cb628b81393471fc3430f2fc893226e74/src/angle.gyp

Comment 2 by dpranke@chromium.org, Apr 20 2016

Components: Build
Labels: -Proj-GN-Migration
Status: Fixed (was: Started)
is this fixed now?

Comment 3 by jbroman@chromium.org, Apr 20 2016 

Yes. I'd been waiting for an ANGLE roll, and one has now happened.

Comment 4 by jmad...@chromium.org, Apr 20 2016 

Ah, I guess the roll script doesn't filter for the chromium: tag.
►

Sign in to add a comment