New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 601171 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove extension API: chrome.cast.channel.setAuthorityKeys

Project Member Reported by eroman@chromium.org, Apr 6 2016

Issue description

Once the certificate chain verification code lands, this API will longer needed.

After the cast extension has been updated and deployed, this API can be removed from Chrome.
 

Comment 1 by mfo...@chromium.org, Jan 19 2017

Owner: erickung@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1

commit ed9773f95712d0477ef7f3f2e7be3d6d79d934b1
Author: mfoltz <mfoltz@chromium.org>
Date: Tue Feb 14 01:36:44 2017

[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for collecting net:: and Cast authentication errors for reporting via onError.

This also removes chrome.cast.channel.setAuthorityKeys() and its tests, which is a no-op and is no longer used.

BUG= 513801 , 601171 

Review-Url: https://codereview.chromium.org/2688463003
Cr-Commit-Position: refs/heads/master@{#450191}

[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/chrome/test/data/extensions/api_test/cast_channel/api/test_authority_keys.html
[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/chrome/test/data/extensions/api_test/cast_channel/api/test_authority_keys.js
[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/chrome/test/data/extensions/api_test/cast_channel/api/test_get_logs.html
[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/chrome/test/data/extensions/api_test/cast_channel/api/test_get_logs.js
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/BUILD.gn
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_channel_api.h
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_channel_apitest.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_socket.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_socket.h
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_transport.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_transport.h
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/cast_transport_unittest.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/keep_alive_delegate_unittest.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/logger.cc
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/logger.h
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/browser/api/cast_channel/logger_unittest.cc
[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/extensions/browser/api/cast_channel/logger_util.cc
[delete] https://crrev.com/f3d8d29fe53a0eafff9088e447451c99a4a92ecf/extensions/browser/api/cast_channel/logger_util.h
[modify] https://crrev.com/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1/extensions/common/api/cast_channel.idl

Comment 3 by mfo...@chromium.org, Feb 14 2017

Cc: erickung@chromium.org
Owner: mfo...@chromium.org
Status: Verified (was: Available)

Sign in to add a comment