New issue
Advanced search Search tips

Issue 601167 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Get deploy_chrome script to deploy mash to device

Project Member Reported by kylec...@chromium.org, Apr 6 2016

Issue description

We need a script to deploy mash files to device like deploy_chrome does for chrome. We have a patch to deploy_chrome from spang@ at https://chromium-review.googlesource.com/#/c/336827/ that works currently.

The changes to deploy "Mojo Applications" and "*.pak" files will need to be moved behind a flag as they don't fit in the standard /opt/google/chrome directory.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884173bed9487d7f79fedd01476850936df7fd01

commit 884173bed9487d7f79fedd01476850936df7fd01
Author: kylechar <kylechar@chromium.org>
Date: Tue Apr 12 14:17:24 2016

Load ash_sysui resources with ResourceLoader.

Create ash_sysui specific .pak files and load them with ResourceLoader.
For now the .pak files are just the previous ash test resources but that
can be changed easily. The ash_sysui .pak files are moved to the
Mojo Applications/ash_sysui subdir.

Moving the resources to the correct subdir will help simplify deploying
mash to a Chromebook. The deploy_chrome script can copy
"Mojo Applications/" only that way.

Also update mus_app resource loading to be a bit cleaner. Remove the
source_set that was built under android as it's unused. Remove the
android_loader.cc/h files which are unused without the target.

BUG= 601167 

Review URL: https://codereview.chromium.org/1874703003

Cr-Commit-Position: refs/heads/master@{#386678}

[modify] https://crrev.com/884173bed9487d7f79fedd01476850936df7fd01/ash/mus/BUILD.gn
[modify] https://crrev.com/884173bed9487d7f79fedd01476850936df7fd01/ash/mus/DEPS
[modify] https://crrev.com/884173bed9487d7f79fedd01476850936df7fd01/ash/mus/sysui_application.cc
[modify] https://crrev.com/884173bed9487d7f79fedd01476850936df7fd01/components/mus/BUILD.gn
[delete] https://crrev.com/62ce30a5789111d0fa5400805df66a1813903208/components/mus/android_loader.cc
[delete] https://crrev.com/62ce30a5789111d0fa5400805df66a1813903208/components/mus/android_loader.h
[modify] https://crrev.com/884173bed9487d7f79fedd01476850936df7fd01/components/mus/mus_app.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/dd2371f961f8ee686d30108dcb886add0575e4a9

commit dd2371f961f8ee686d30108dcb886add0575e4a9
Author: kylechar <kylechar@chromium.org>
Date: Mon Apr 11 15:09:31 2016

deploy_chrome: Deploy mus+ash specific files.

Add a command line flag --mash to deploy_chrome to copy files needed for
mus+ash. This is the mojo_runner executable and contents of Mojo
Applications directory.

Small changes:
 - Remove user_mesa_platform_null from $GN_ARGS as it's invalid.
 - Update deploy_chrome to also strip *.mojo binaries.

BUG= chromium:601167 
TEST=Tested locally deploying mash to a Pixel.

Change-Id: I80ba02b5f11d854c001821fb17268466f3e7a09b
Reviewed-on: https://chromium-review.googlesource.com/338053
Commit-Ready: Kyle Charbonneau <kylechar@chromium.org>
Tested-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/dd2371f961f8ee686d30108dcb886add0575e4a9/cli/cros/cros_chrome_sdk.py
[modify] https://crrev.com/dd2371f961f8ee686d30108dcb886add0575e4a9/scripts/deploy_chrome.py
[modify] https://crrev.com/dd2371f961f8ee686d30108dcb886add0575e4a9/lib/chrome_util.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c16821a44240a0be862f9756fa8c5e210e890b66

commit c16821a44240a0be862f9756fa8c5e210e890b66
Author: kylechar <kylechar@chromium.org>
Date: Fri Apr 15 17:49:55 2016

deploy_chrome: Copy additional files for mash.

Copy manifests in root output directory for mus+ash.

BUG= chromium:601167 
TEST=Tested locally deploying mash to a Pixel.

Change-Id: I4a6fb25d935b60c5ff81e479d1df4730307c580d
Reviewed-on: https://chromium-review.googlesource.com/339260
Commit-Ready: Kyle Charbonneau <kylechar@chromium.org>
Tested-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c16821a44240a0be862f9756fa8c5e210e890b66/lib/chrome_util.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2016

Status: Fixed (was: Untriaged)
Cc: adlr@chromium.org sadrul@chromium.org kylec...@chromium.org osh...@chromium.org
 Issue 564262  has been merged into this issue.
Components: Internals>Services>WindowService
Components: -MUS>Phase>1

Sign in to add a comment