mini_installer.exe doesn't work with GN (archive path is incorrect) |
|||||
Issue descriptionVersion: r385455 OS: Win10 What steps will reproduce the problem? (1) Build mini_installer with GN (mine is component+branded but don't think it matters) (2) Run mini_installer.exe --verbose-logging Log: (...) [0406/143017:VERBOSE1:setup_util.cc(100)] Looking for Chrome version folder under C:\Users\Gabriel\AppData\Local\Google\Chrome\Temp\source2060_32606\Chrome-bin [0406/143017:ERROR:setup_main.cc(1498)] Did not find any valid version in installer. (...) The same configuration build with GYP goes through the same steps but succeeds: (...) [0406/143052:VERBOSE1:setup_util.cc(100)] Looking for Chrome version folder under C:\Users\Gabriel\AppData\Local\Google\Chrome\Temp\source7532_17276\Chrome-bin [0406/143052:VERBOSE1:setup_util.cc(111)] directory found: 51.0.2702.0 [0406/143052:VERBOSE1:setup_main.cc(1503)] version to install: 51.0.2702.0 (...) Opening mini_installer.exe with 7-zip highlights the issue: In the GN build the path is: mini_installer.exe\gen\temp_installer_archive\Chrome-bin\51.0.2702.0\ In the GYP build the path is: mini_installer.exe\Chrome-bin\51.0.2702.0\ The incorrect path is present in the chrome.7z generated by GN (i.e. that's likely the incorrect step). Note: this is after issue 596885 having been fixed.
,
Apr 12 2016
Explicitly CC'ing people per Dirk's request on chromium-dev, this needs to be fixed before we shut off GYP on Windows for devs (assuming P1 + Windows + Proj-GN-Migration labels were sufficient but just making extra sure :-)). Thanks, Gab
,
Apr 12 2016
The labels are good enough :). Disclaiming ownership as I'm probably not going to work on this right away, so someone else is free to step up ...
,
Apr 12 2016
I just grabbed it.
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d7f454406379fbf4e9221ff5328f4d364d754ca commit 2d7f454406379fbf4e9221ff5328f4d364d754ca Author: brucedawson <brucedawson@chromium.org> Date: Mon Apr 18 17:27:54 2016 Fix mini_installer archive paths with gn Due to a subtlety of 7za's behavior the file paths in the mini_installer archive were incorrect in gn builds. This is a trivial change to make them behave the same as in gyp builds. BUG= 601132 Review URL: https://codereview.chromium.org/1893823002 Cr-Commit-Position: refs/heads/master@{#387939} [modify] https://crrev.com/2d7f454406379fbf4e9221ff5328f4d364d754ca/chrome/tools/build/win/create_installer_archive.py
,
Apr 19 2016
done?
,
Apr 19 2016
looks that way. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gab@chromium.org
, Apr 6 2016