CQ dry-run seems to still check tree status after all tryjobs completed |
||||||
Issue descriptionFor CQ dry-run, I think it should be done right after all tryjobs completed. However, in this CL https://codereview.chromium.org/1866053002/#ps1 , the dry-run is blocked on checking tree status because the tree was closed. Is that expected or a bug?
,
Apr 15 2016
AFAIK, the only check we ignore is whether LGTM has been given or not (but the requester still has to be a committer or have tryjob access). Perhaps we can add an exception for the tree-closed as well.
,
Apr 26 2016
Doing it as part of presubmit cleanup for Gerrit.
,
Apr 26 2016
,
Apr 27 2016
,
Apr 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/69c995a2f370da4944fa8ad6a7ae4415010e929e commit 69c995a2f370da4944fa8ad6a7ae4415010e929e Author: tandrii <tandrii@google.com> Date: Wed Apr 27 12:49:39 2016
,
Apr 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/9c82e5785b55a09fd1466a0aef4a84d42b99c525 commit 9c82e5785b55a09fd1466a0aef4a84d42b99c525 Author: tandrii <tandrii@google.com> Date: Wed Apr 27 13:00:29 2016
,
Apr 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/f6a32a0553473344a66a850dc703bda4c10ce156 commit f6a32a0553473344a66a850dc703bda4c10ce156 Author: tandrii <tandrii@google.com> Date: Wed Apr 27 13:04:40 2016
,
Apr 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8c508b73f67b563a5754d94c8a54f93ea31ab1a2 commit 8c508b73f67b563a5754d94c8a54f93ea31ab1a2 Author: tandrii <tandrii@google.com> Date: Wed Apr 27 13:29:59 2016
,
Apr 27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/57c454c39b763d3167418d16f58dbd7beb243603 commit 57c454c39b763d3167418d16f58dbd7beb243603 Author: tandrii <tandrii@google.com> Date: Wed Apr 27 15:18:49 2016
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9492f053318304887b832811fa8cbafc9e827a7f commit 9492f053318304887b832811fa8cbafc9e827a7f Author: tandrii <tandrii@chromium.org> Date: Wed Apr 27 16:33:33 2016 Rietveld: schedule presubmit tryjobs with dry_run property. R=machenbach@chromium.org,andybons@chromium.org BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1920833005 [modify] https://crrev.com/9492f053318304887b832811fa8cbafc9e827a7f/appengine/chromium_rietveld/codereview/buildbucket.py
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c39431ae2cd95ed79df8180095f1f1c9374fc35b commit c39431ae2cd95ed79df8180095f1f1c9374fc35b Author: tandrii@chromium.org <tandrii@chromium.org> Date: Thu Apr 28 05:40:43 2016 git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1926663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300265 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/c39431ae2cd95ed79df8180095f1f1c9374fc35b/git_cl.py
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/2869cf2c4d008ca7d945da6140c9b3ffffce835a commit 2869cf2c4d008ca7d945da6140c9b3ffffce835a Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Thu Apr 28 05:45:57 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/c39431ae2cd95ed79df8180095f1f1c9374fc35b git cl try: don't skip presubmit builders, but set dry_run property. (tandrii@chromium.org) R=machenbach@chromium.org,sergiyb@chromium.org,tandrii@chromium.org BUG=594127, 601128 ,591030 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1930803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300266 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/2869cf2c4d008ca7d945da6140c9b3ffffce835a/infra/config/recipes.cfg
,
Apr 28 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87150 ------------------------------------------------------------------ r87150 | recipe-roller@chromium.org | 2016-04-28T06:03:06.046663Z -----------------------------------------------------------------
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9dea2ac16f91ac30b574fb0e608618198dc74d4e commit 9dea2ac16f91ac30b574fb0e608618198dc74d4e Author: tandrii@chromium.org <tandrii@chromium.org> Date: Thu Apr 28 06:26:20 2016 Remove manual check using Rietveld for dry run. It's now passed using command line flags. This depends on https://codereview.chromium.org/1931633002, which actually uses this command line flag. R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG= 601128 Review-Url: https://codereview.chromium.org/1929653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300268 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/9dea2ac16f91ac30b574fb0e608618198dc74d4e/presubmit_canned_checks.py [modify] https://crrev.com/9dea2ac16f91ac30b574fb0e608618198dc74d4e/tests/presubmit_unittest.py
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/ac84792b70b41d526ddcd6ad04a0b4d3bf3e95b1 commit ac84792b70b41d526ddcd6ad04a0b4d3bf3e95b1 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Thu Apr 28 06:37:04 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/9dea2ac16f91ac30b574fb0e608618198dc74d4e Remove manual check using Rietveld for dry run. (tandrii@chromium.org) R=phajdan.jr@chromium.org,sergiyb@chromium.org,tandrii@chromium.org BUG= 601128 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1931773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300269 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/ac84792b70b41d526ddcd6ad04a0b4d3bf3e95b1/infra/config/recipes.cfg
,
Apr 28 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87151 ------------------------------------------------------------------ r87151 | recipe-roller@chromium.org | 2016-04-28T06:42:55.955939Z -----------------------------------------------------------------
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/3ea2614b3ef1e38258f3b88dc0d9ebacb53fb660 commit 3ea2614b3ef1e38258f3b88dc0d9ebacb53fb660 Author: tandrii@chromium.org <tandrii@chromium.org> Date: Thu Apr 28 12:29:10 2016 Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/ reverting first, then investigating. Original issue's description: > git cl try: don't skip presubmit builders, but set dry_run property. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG= 601128 ,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 TBR=machenbach@chromium.org,sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1929483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300274 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/3ea2614b3ef1e38258f3b88dc0d9ebacb53fb660/git_cl.py
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/4fd2f8a7602063dfa08bb198955981aa5cf158f1 commit 4fd2f8a7602063dfa08bb198955981aa5cf158f1 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Thu Apr 28 12:36:28 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/3ea2614b3ef1e38258f3b88dc0d9ebacb53fb660 Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ ) (tandrii@chromium.org) R=machenbach@chromium.org,sergiyb@chromium.org,tandrii@chromium.org BUG=594127, 601128 ,591030 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1924743007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300275 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/4fd2f8a7602063dfa08bb198955981aa5cf158f1/infra/config/recipes.cfg
,
Apr 28 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87154 ------------------------------------------------------------------ r87154 | recipe-roller@chromium.org | 2016-04-28T12:42:51.478641Z -----------------------------------------------------------------
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c68f7b51f56a30828386b5aeb64aec0eb3dd080b commit c68f7b51f56a30828386b5aeb64aec0eb3dd080b Author: tandrii@chromium.org <tandrii@chromium.org> Date: Thu Apr 28 19:42:47 2016 Reland of git cl try: don't skip presubmit builders, but set dry_run property. With a fix: actually set dry_run for presubmit, and don't set it for other builders. R=machenbach@chromium.org,sergiyb@chromium.org BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1926663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/c68f7b51f56a30828386b5aeb64aec0eb3dd080b/git_cl.py
,
Apr 28 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87184 ------------------------------------------------------------------ r87184 | recipe-roller@chromium.org | 2016-04-28T22:23:14.656944Z -----------------------------------------------------------------
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c2dfcb8ddb18ff4bfd75a7ed255b71d7f7ad5d06 commit c2dfcb8ddb18ff4bfd75a7ed255b71d7f7ad5d06 Author: machenbach@chromium.org <machenbach@chromium.org> Date: Fri Apr 29 12:21:36 2016 Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Now only presubmit is scheduled on dry run, example CL: https://codereview.chromium.org/1804003002 Original issue's description: > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG= 601128 ,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1928373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300337 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/c2dfcb8ddb18ff4bfd75a7ed255b71d7f7ad5d06/git_cl.py
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/2403e80b59284948692642af4ca4b53bfbdac176 commit 2403e80b59284948692642af4ca4b53bfbdac176 Author: machenbach@chromium.org <machenbach@chromium.org> Date: Fri Apr 29 12:34:42 2016 Reland of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1928373002/ ) Reason for revert: Was me - too fast to pull the revert trigger. The CL in question has notry set to true :( Original issue's description: > Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) > > Reason for revert: > Now only presubmit is scheduled on dry run, example CL: > https://codereview.chromium.org/1804003002 > > Original issue's description: > > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > > > R=machenbach@chromium.org,sergiyb@chromium.org > > BUG= 601128 ,594127,591030 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 > > TBR=sergiyb@chromium.org,tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 601128 ,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300337 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 601128 ,594127,591030 Review-Url: https://codereview.chromium.org/1930363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300338 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/2403e80b59284948692642af4ca4b53bfbdac176/git_cl.py
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/8ea646288a89a2a00b78ed5d4425a615009680bd commit 8ea646288a89a2a00b78ed5d4425a615009680bd Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Fri Apr 29 13:06:27 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/6cfbbcf467d85de87004733aa421b7fa1bc62e48 depot_tools: add dependencies on infra_paths (phajdan.jr@chromium.org) https://crrev.com/c2dfcb8ddb18ff4bfd75a7ed255b71d7f7ad5d06 Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) (machenbach@chromium.org) https://crrev.com/2403e80b59284948692642af4ca4b53bfbdac176 Reland of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1928373002/ ) (machenbach@chromium.org) R=tandrii@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,phajdan.jr@chromium.org BUG=594127, chromium:605919 , 601128 ,591030 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1928383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300340 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/8ea646288a89a2a00b78ed5d4425a615009680bd/infra/config/recipes.cfg
,
Apr 29 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87218 ------------------------------------------------------------------ r87218 | recipe-roller@chromium.org | 2016-04-29T13:17:05.331860Z -----------------------------------------------------------------
,
Apr 29 2016
Oh, wait, sorry, I misunderstood the bug (after 26 comments!). The presubmit is builder is fine. It's the tree openness verifier which is should be fixed. Damn it.
,
Apr 29 2016
2 line CL to fix this: https://chromereviews.googleplex.com/414207013
,
Apr 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/41fa4c3783732e530741580592aa20d65732881f commit 41fa4c3783732e530741580592aa20d65732881f Author: tandrii <tandrii@google.com> Date: Fri Apr 29 19:55:21 2016
,
Apr 29 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jpar...@google.com
, Apr 11 2016