Blimp 0.5 client should accept poorly-formatted URLs |
|||
Issue descriptionThe Blimp 0.5 client appears to hang when a URL is entered without an http:// prefix. More broadly, the client should attempt to rectify URLs before sending them to the engine. For bonus points, if text entered into the URL bar does not look like a URL, do a Google search with that as the query string instead.
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87714dd50611f6ea33b93383d9af4572f7ccb661 commit 87714dd50611f6ea33b93383d9af4572f7ccb661 Author: haibinlu <haibinlu@chromium.org> Date: Mon Apr 25 19:45:37 2016 [Blimp Client] Fixes up URL before sending it to Engine. Uses url_formatter::FixupURL to convert "google.com" to "http://google.com". It also convert "movie" to "http://movie/" (which is a valid GURL). We check if the host has a '.' in it. If not, we use google search. This heuristic is wrong since valid GRULs such as "http://[2001:db8::2]/" (IPv6 literals) and "chrome://version/" do not have '.' in their host. However, it allows us to test v0.5 in a much easier way. BUG= 601117 Review URL: https://codereview.chromium.org/1869783005 Cr-Commit-Position: refs/heads/master@{#389543} [modify] https://crrev.com/87714dd50611f6ea33b93383d9af4572f7ccb661/blimp/client/BUILD.gn [modify] https://crrev.com/87714dd50611f6ea33b93383d9af4572f7ccb661/blimp/client/feature/navigation_feature.cc [modify] https://crrev.com/87714dd50611f6ea33b93383d9af4572f7ccb661/blimp/client/feature/navigation_feature_unittest.cc [modify] https://crrev.com/87714dd50611f6ea33b93383d9af4572f7ccb661/blimp/engine/session/blimp_engine_session.cc
,
Apr 25 2016
,
Dec 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by haibinlu@chromium.org
, Apr 6 2016Status: Started (was: Untriaged)