Issue 601105 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	----
Closed:	May 2016
Cc:	bleung@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug-Regression
Kernel-3.18 merge-merged-chromeos-3.18 Via-Wizard VerifyIn-53 VerifyIn-54 Bulk-Verified

Build break when selecting kernel-3_18 for amd64-generic board

Reported by gs0...@gmail.com, Apr 6 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.63 Safari/537.36
Platform: amd64-generic

Steps to reproduce the problem:
1. cros_workon-amd64-generic start sys-kernel/chromeos-kernel-3_18
2. emerge-amd64-generic sys-kernel/chromeos-kernel-3_18

What is the expected behavior?
Build v3.18 amd64-generic kernel successfully

What went wrong?
Compilation error due to redefined DP_LINK_STATUS_SIZE, since commit 9c37c5a7c4b6 refined DP_LINK_STATUS_SIZE to 11

/mnt/host/source/src/third_party/kernel/v3.18/drivers/gpu/drm/gma500/cdv_intel_dp.c:55:0: error: "DP_LINK_STATUS_SIZE" redefined [-Werror]
 #define DP_LINK_STATUS_SIZE 6
 ^

Did this work before? Yes 

Chrome version: 49.0.2623.63  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

Comment 1 by gs0...@gmail.com, Apr 6 2016

https://chromium-review.googlesource.com/337543 UPSTREAM: drm/gma500: Remove DP_LINK_STATUS_SIZE redefinition

Comment 2 by bleung@chromium.org, Apr 11 2016

Cc: bleung@chromium.org
Labels: Kernel-3.18
Status: Available (was: Unconfirmed)

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2016

Labels: merge-merged-chromeos-3.18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c0593b1beebb4cebe4c56e66870815908ce1d57d

commit c0593b1beebb4cebe4c56e66870815908ce1d57d
Author: Thierry Reding <treding@nvidia.com>
Date: Thu Sep 24 08:07:32 2015

UPSTREAM: drm/gma500: Remove DP_LINK_STATUS_SIZE redefinition

The DRM/DP helpers already contain a definition for this macro. Remove
the duplicate in the GMA500 driver to avoid having to keep both updated
synchronously.

BUG= chromium:601105 
TEST=emerge-amd64-generic sys-kernel/chromeos-kernel-3_18

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
(cherry picked from commit 5fbec9014b5ab9deecb3338cd14aae82ed14d0ec)
Signed-off-by: Harry Pan <harry.pan@intel.com>

Change-Id: I1384ddd05df7307fbb9c1a4b1acdc62873262371
Reviewed-on: https://chromium-review.googlesource.com/337543
Commit-Ready: Harry Pan <harry.pan@intel.com>
Tested-by: Harry Pan <harry.pan@intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/c0593b1beebb4cebe4c56e66870815908ce1d57d/drivers/gpu/drm/gma500/cdv_intel_dp.c