New issue
Advanced search Search tips

Issue 601094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Make method names in safe_browsing_db/database_manager consistent

Project Member Reported by vakh@chromium.org, Apr 6 2016

Issue description

src/components/safe_browsing_db/database_manager.* has inconsistent method names. While all other methods use CamelCase (with first letter capital), one doesn't: download_protection_enabled

https://code.google.com/p/chromium/codesearch#search/&q=download_protection_enabled

 

Comment 1 by mattm@chromium.org, Apr 6 2016

Note that the lower_underscore style is specified by the style guide for cheap methods: http://google.github.io/styleguide/cppguide.html#Function_Names
Though since that method is virtual now it does seem a bit off.

Comment 2 by vakh@chromium.org, Apr 7 2016

You're right. It was reasonable the way it was implemented at first. However, as you mentioned, since that method is virtual now, there's no guarantee that the implementation would be cheap. The CL is out for review, if you'd like to do a quick LGTM: https://codereview.chromium.org/1865763002/ :)
Nathan has LGTM'd in spirit already.

Comment 4 by vakh@chromium.org, Apr 7 2016

Status: Fixed (was: Assigned)

Sign in to add a comment