"Show offline bookmarks" button is shown when there is no offline page |
|||
Issue descriptionDevice: Any android Application Version (from "Chrome Settings > About Chrome"): 51.0.2700.2 Operating System (from "Chrome Settings > About Chrome"): Android 5.1.1 Location: <city/country of issue> Network: <WiFi, 2G/3G/4G, carrier> Steps to reproduce: 1. Ensure there are no offline pages saved 2. Go offline 3. Navigate to any page Observed behavior: Dino page with "You are offline" message with "Show offline bookmarks" button Expected behavior: Dino page with "You are offline" message without "Show offline bookmarks" button, as there are no offline bookmarks on the device. If possible, attach a bug report and/or screenshot. (Android settings > About Phone > tap Build number 7 times
,
Apr 7 2016
This occurs because we did not write client ID when we upgrade the entries in old bookmark ID format.
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c4aada470737b1708ab65a92e5116634c67550c commit 5c4aada470737b1708ab65a92e5116634c67550c Author: jianli <jianli@chromium.org> Date: Fri Apr 08 19:53:18 2016 Fix the issue that client id is not saved when upgrading the offline metadata store BUG= 601071 Review URL: https://codereview.chromium.org/1869243002 Cr-Commit-Position: refs/heads/master@{#386167} [modify] https://crrev.com/5c4aada470737b1708ab65a92e5116634c67550c/components/offline_pages/offline_page_metadata_store_impl.cc [modify] https://crrev.com/5c4aada470737b1708ab65a92e5116634c67550c/components/offline_pages/offline_page_metadata_store_impl.h [modify] https://crrev.com/5c4aada470737b1708ab65a92e5116634c67550c/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
,
Apr 8 2016
This is caused by https://codereview.chromium.org/1694863003/. So here're steps to repro this: 1) Install a Canary build before 51.0.2666.0. For example, https://.../51.0.2662.0/arm/ChromeCanary.apk 2) Save an offline page. "Saved offline" filter page shows the saved page. 3) Install a Canary build after 51.0.2666.0, with data kept. For example, https://.../51.0.2670.0/arm/ChromeCanary.apk 4) Launch Chrome Canary and go to "Saved offline" filter page. It is expected to still show the saved page. But actually it is empty. To verify the fix, you can install a build after this fix.
,
Apr 11 2016
Verified fixed in 52.0.2705.0 I was able to repro the problem using the steps above, and verified it's fixed upgrading from 51.0.2662.0 to 52.0.2705.0 where the offline bookmark is still listed. Also if there are no offline bookmarks, then the "Show offline bookmarks" button doesn't appear. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jianli@chromium.org
, Apr 7 2016Summary: "Show offline bookmarks" button is shown when there is no offline page (was: Issue Summary)