New issue
Advanced search Search tips

Issue 601069 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

crosperf: could not run pagecycler benchmarks.

Project Member Reported by yunlian@chromium.org, Apr 6 2016

Issue description

With the benchamrk below,

benchmark: pagecycler.typical_25 {
    suite: telemetry_Crosperf
    iterations: 1
}

 /usr/bin/test_that --autotest_dir ~/trunk/src/third_party/autotest/files --fast --board=falco --args=" run_local=True test=pagecycler.typical_25 " 172.17.211.200 telemetry_Crosperf

fails with:

Getting DEPs: python /var/cache/chromeos-cache/distfiles/target/chrome-src-internal/src/tools/perf/fetch_benchmark_deps.py pagecycler.typical_25

Traceback (most recent call last):
  <module> at /var/cache/chromeos-cache/distfiles/target/chrome-src-internal/src/tools/perf/fetch_benchmark_deps.py:90
    main()
  main at /var/cache/chromeos-cache/distfiles/target/chrome-src-internal/src/tools/perf/fetch_benchmark_deps.py:73
    raise ValueError('No such benchmark: %s' % name)
ValueError: No such benchmark:  pagecycler.typical_25

 
Shouldn't it be page_cycler.typical_25, rather than pagecycler.typical_25?

Comment 2 by cmt...@chromium.org, Apr 13 2016

Owner: cmt...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by cmt...@chromium.org, Apr 13 2016

The page_cycler test seems to be exercising an otherwise untested path in telemetry_Crosperf, and is causing telemetry_Crosperf to fail due to some missing import statements (after recent telemetry_Crosperf changes to deal with changed autotest output format).

I'm in the process of creating a CL to fix the missing import statements.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2cfe52ed13587f2d60df53b2c12d15d00eecaf1f

commit 2cfe52ed13587f2d60df53b2c12d15d00eecaf1f
Author: Caroline Tice <cmtice@google.com>
Date: Wed Apr 13 20:11:41 2016

[crosperf] Add missing import statements.

telemetry_Crosperf.py was missing two import statements.  This
fixes that.

BUG= chromium:601069 
TEST=Tested changes in role account with page_cycler.typical_25.

Change-Id: I94b58338fc437191bae2095797e25c0f6660e6af
Reviewed-on: https://chromium-review.googlesource.com/338824
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2cfe52ed13587f2d60df53b2c12d15d00eecaf1f/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Comment 5 by cmt...@chromium.org, Apr 14 2016

Status: Fixed (was: Assigned)

Comment 6 by cmt...@chromium.org, Mar 17 2017

Status: Verified (was: Fixed)

Sign in to add a comment