New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601065 link

Starred by 1 user
Status: Fixed
Owner:
█ amp@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Media Router] Cloud discovery not started

Project Member Reported by amp@chromium.org, Apr 6 2016 
Cloud discovery is based off of sink queries.  If the MRPM reports all providers as UNAVAILABLE then queries are not forwarded onto the providers and cloud discovery is skipped.

I have observed this on ChromeOS and Mac, but it does not occur on Linux.  Windows has not been verified either way yet.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85

commit c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85
Author: amp <amp@chromium.org>
Date: Sat Apr 16 03:20:26 2016

[Media Router] Wire through a new MRPM call to update media sinks.

This will allow any discovery which is based off of sink queries (such as the Cloud MRP) an opportuntity to find new sinks even if the MRP is marked as UNVAILABLE.

BUG= 601065 

Review URL: https://codereview.chromium.org/1862913004

Cr-Commit-Position: refs/heads/master@{#387809}

[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/extensions/renderer/resources/media_router_bindings.js
[modify] https://crrev.com/c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85/tools/metrics/histograms/histograms.xml

Comment 2 by amp@chromium.org, Apr 18 2016

Status: Fixed (was: Started)

Comment 3 by amp@chromium.org, Apr 18 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 18 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 Deleted

Comment 6 by gov...@chromium.org, Apr 18 2016 

Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a9037b31ef97b64b94731fb61ba81057fb3e8a

commit 45a9037b31ef97b64b94731fb61ba81057fb3e8a
Author: Jennifer Apacible <apacible@google.com>
Date: Mon Apr 18 21:14:41 2016

[Media Router] Wire through a new MRPM call to update media sinks.

This will allow any discovery which is based off of sink queries (such as the Cloud MRP) an opportuntity to find new sinks even if the MRP is marked as UNVAILABLE.

BUG= 601065 

Review URL: https://codereview.chromium.org/1862913004

Cr-Commit-Position: refs/heads/master@{#387809}
(cherry picked from commit c2f9e3a5a7bf211b14c1be7ae8bfa65a518c2b85)

Review URL: https://codereview.chromium.org/1895783003 .

Cr-Commit-Position: refs/branch-heads/2704@{#111}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/extensions/renderer/resources/media_router_bindings.js
[modify] https://crrev.com/45a9037b31ef97b64b94731fb61ba81057fb3e8a/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment